Conversation
hyeeum
requested review from
1971123-seongmin,
HAJIEUN02,
jihyunniiii and
kamja0510
greedy0110
approved these changes
Dec 8, 2024
1971123-seongmin
approved these changes
Dec 8, 2024
Member
1971123-seongmin
left a comment
1971123-seongmin
left a comment
There was a problem hiding this comment.
UseCase 적용하시느라 정말 고생많으셨어요 ^^
|
|
||
| @Module | ||
| @InstallIn(SingletonComponent::class) | ||
| internal abstract class DataSourceModule { |
Member
There was a problem hiding this comment.
여기에 internal을 붙이시는 이유가 따로 있나요??
kamja0510
approved these changes
Dec 8, 2024
kamja0510
left a comment
kamja0510
left a comment
There was a problem hiding this comment.
애초에 clean architecture 잘해놓으셔서 큰 변화가 없으시네요
이번 과제하는데 코드 도움 많이 받았습니다!
| import org.sopt.and.data.dto.response.ResponseSignUpDto | ||
|
|
||
| interface WavveDataSource { | ||
| interface AuthDataSource { |
| @HiltViewModel | ||
| class MyViewModel @Inject constructor( | ||
| private val wavveRepository: WavveRepository | ||
| private val getHobbyUseCase : MyUseCase |
There was a problem hiding this comment.
viewmodel이 repository 의존성을 가지는것과 usecase를 가지는 것과 어떻게 다른가요??
jihyunniiii
reviewed
Dec 16, 2024
| @@ -1,4 +1,4 @@ | |||
| package org.sopt.and.component | |||
| package org.sopt.and.core.component | |||
Contributor
There was a problem hiding this comment.
core 패키지에는 보통 어떤 친구들을 넣어놓으시는지 궁금해요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢
기존의 service datasource repository 를 하나로 통합해서 사용했는데 이번 주차에서는 각각 분리해보았습니다 :)
뭐했다고 벌써 6주차 과제 마감일일까요
뭐했다고 벌써 다음 세미나가 7주차 세미나일까요...
후엥