Fix duplicate issue detection logic#1273
Conversation
|
@rohan-pandeyy Please review it. Thanks |
WalkthroughExclude the current issue from the upstream comparison set and add debug prints in the Python similarity step: log the configured threshold, current issue id and candidate count, and per-candidate (issue number, score, title) diagnostics before writing ChangesDuplicate Detection Fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @DhruvK278, could you please test this implementation on your fork branch and share a screen recording here? Verify the following:
|
here is the working test: |
rohan-pandeyy
left a comment
There was a problem hiding this comment.
Thank you for your contribution! @DhruvK278
Addressed Issues:
Exclude the newly opened issue from the semantic duplicate comparison set to prevent self-matching and false duplicate detection.
Fixes #1272
Screenshots/Recordings:
https://drive.google.com/file/d/1ir6AoR43aPjuTA1XqMDoogqa9GIscX1t/view?usp=sharing
Before
After
No wrong identification of duplicate issue
AI Usage Disclosure:
We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.
Check one of the checkboxes below:
I have used the following AI models and tools: NONE
Checklist
Summary by CodeRabbit
Bug Fixes
Chores