Fix text padding issue where letters were getting cut off by Aditya30ag · Pull Request #814 · AOSSIE-Org/PictoPy

Aditya30ag · 2025-12-21T16:43:08Z

#813 issue closing

Summary by CodeRabbit

Style
- Removed light background on FAQ section, favoring transparent/dark baseline while preserving dark-mode styling
- Adjusted vertical spacing (py-2) on FAQ and multiple landing headings for improved visual hierarchy
- Updated footer to a light-by-default design with dark-mode support, added a subtle top border and smooth color transitions for theme toggling

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-21T16:43:28Z

📝 Walkthrough

Walkthrough

Removed a light background on the FAQ section, added small vertical padding to multiple headings, and updated the footer to use light/dark-aware colors with a top border and color transition. All edits are presentational CSS class changes.

Changes

Cohort / File(s)	Summary
FAQ section styling `landing-page/src/Pages/FaqPage/FAQ.tsx`	Removed `bg-gray-50` (light background) from the section wrapper while keeping dark-mode classes; added `py-2` to the FAQ header `h2`.
Heading padding adjustments `landing-page/src/Pages/Landing page/Home1.tsx`, `landing-page/src/Pages/pictopy-landing.tsx`	Added `py-2` to heading elements to increase vertical padding; purely presentational.
Footer theme & transition `landing-page/src/Pages/Footer/Footer.tsx`	Switched root classes to `bg-white dark:bg-black text-black dark:text-white`, added `border-t border-black dark:border-white` and `transition-colors duration-300`; presentational only.
Manifest `package.json`	Included in manifest/diff; no API/signature changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

UI, easy

Poem

Padding hops in, margins mild,
Footer dons a border, styled.
Headings breathe with extra space,
I nibble classes—gentle grace.
A rabbit winks, the layout's smiled. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change across all files: adding vertical padding (py-2) to multiple heading elements to fix text getting cut off, and adjusting styling in FAQ and Footer components.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c9c1ca and 30e5627.

📒 Files selected for processing (2)

landing-page/src/Pages/FaqPage/FAQ.tsx
landing-page/src/Pages/Footer/Footer.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

landing-page/src/Pages/Footer/Footer.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Backend Tests

🔇 Additional comments (2)

landing-page/src/Pages/FaqPage/FAQ.tsx (2)

48-48: LGTM! Background removal implemented as suggested.

The removal of bg-gray-50 addresses the previous reviewer's feedback and provides a cleaner, more consistent background transition between light and dark modes.

58-58: LGTM! Padding addition correctly fixes gradient text clipping.

The py-2 addition provides necessary vertical padding to prevent letters with descenders (like g, y, p) from being clipped when using bg-clip-text with gradients. This directly addresses the PR's objective and implements the previous reviewer's suggestion.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Aditya30ag · 2025-12-21T16:43:51Z

@raghavpuri31 please have a look

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

landing-page/src/Pages/Footer/Footer.tsx (1)
30-32: Inner border invisible in light mode.

The inner border-white will be invisible against the white background in light mode. Update to match the outer border's dark-mode-aware pattern.
🔎 Suggested fix
-        <div className="mt-4 text-center border-t border-white pt-2">
+        <div className="mt-4 text-center border-t border-black dark:border-white pt-2">

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d07d817 and 96b663c.

📒 Files selected for processing (4)

landing-page/src/Pages/FaqPage/FAQ.tsx (1 hunks)
landing-page/src/Pages/Footer/Footer.tsx (1 hunks)
landing-page/src/Pages/Landing page/Home1.tsx (1 hunks)
landing-page/src/Pages/pictopy-landing.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Backend Tests

🔇 Additional comments (4)

landing-page/src/Pages/Landing page/Home1.tsx (1)

17-24: LGTM!

The py-2 addition appropriately addresses gradient text clipping. This is a common fix for bg-clip-text elements where descenders (like the 'y' in "PictoPy") can get cut off without sufficient vertical padding.

landing-page/src/Pages/pictopy-landing.tsx (2)

22-22: LGTM!

The section styling with dark mode support (bg-white dark:bg-black) and transition is consistent with the theming approach across the landing pages.

59-61: LGTM!

The py-2 padding fix for the gradient heading is consistent with the same fix applied in Home1.tsx, ensuring uniform text display across components.

landing-page/src/Pages/FaqPage/FAQ.tsx (1)

58-60: LGTM!

The py-2 fix for gradient text clipping is consistent with other headings in this PR. The reduced bottom margin (mb-2 from mb-6) tightens the spacing between the heading and subtext—verify this provides the desired visual balance.

rohan-pandeyy

@Aditya30ag Address the footer text color issue. The other suggestions are improvements for refactoring.

Aditya30ag · 2025-12-27T05:49:29Z

@rohan-pandeyy
I’ve fixed the requested issues and applied three small edits:

Footer (`landing-page/src/Pages/Footer/Footer.tsx`)

Changed class from text-white to text-black dark:text-white so text is visible in light mode.

FAQ (`landing-page/src/Pages/FaqPage/FAQ.tsx`)

Removed bg-gray-50 from the section root (light background removed).
Restored h2 spacing: changed mb-2 back to mb-6.

Aditya30ag · 2025-12-27T05:50:41Z

@rahulharpal1603 Please check now it is ready

rahulharpal1603

Thanks @Aditya30ag!

Fix text padding issue where letters were getting cut off

96b663c

coderabbitai Bot reviewed Dec 21, 2025

View reviewed changes

Comment thread landing-page/src/Pages/Footer/Footer.tsx Outdated

rohan-pandeyy requested changes Dec 26, 2025

View reviewed changes

Comment thread landing-page/src/Pages/Footer/Footer.tsx Outdated

Comment thread landing-page/src/Pages/FaqPage/FAQ.tsx Outdated

Merge branch 'main' into fix-text-padding

3c9c1ca

fixed the requested issues

30e5627

rahulharpal1603 approved these changes Feb 4, 2026

View reviewed changes

rahulharpal1603 merged commit 5ca5935 into AOSSIE-Org:main Feb 4, 2026
6 checks passed

coderabbitai Bot mentioned this pull request Feb 20, 2026

style(landing-page): improve dotted background visibility with transp… #1187

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix text padding issue where letters were getting cut off#814

Fix text padding issue where letters were getting cut off#814
rahulharpal1603 merged 3 commits into
AOSSIE-Org:mainfrom
Aditya30ag:fix-text-padding

Aditya30ag commented Dec 21, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Dec 21, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

Uh oh!

Aditya30ag commented Dec 21, 2025

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

rohan-pandeyy left a comment

Uh oh!

Uh oh!

Uh oh!

Aditya30ag commented Dec 27, 2025

Uh oh!

Aditya30ag commented Dec 27, 2025

Uh oh!

rahulharpal1603 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Aditya30ag commented Dec 21, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Poem

Pre-merge checks and finishing touches

Uh oh!

Aditya30ag commented Dec 21, 2025

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rohan-pandeyy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Aditya30ag commented Dec 27, 2025

Footer (landing-page/src/Pages/Footer/Footer.tsx)

FAQ (landing-page/src/Pages/FaqPage/FAQ.tsx)

Uh oh!

Aditya30ag commented Dec 27, 2025

Uh oh!

rahulharpal1603 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Aditya30ag commented Dec 21, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Dec 21, 2025 •

edited

Loading

Footer (`landing-page/src/Pages/Footer/Footer.tsx`)

FAQ (`landing-page/src/Pages/FaqPage/FAQ.tsx`)