Skip to content

UI: add informative footer to landing page#816

Closed
singhabhimanyu9838 wants to merge 1 commit into
AOSSIE-Org:mainfrom
singhabhimanyu9838:feat/add-footer-landing-page
Closed

UI: add informative footer to landing page#816
singhabhimanyu9838 wants to merge 1 commit into
AOSSIE-Org:mainfrom
singhabhimanyu9838:feat/add-footer-landing-page

Conversation

@singhabhimanyu9838

@singhabhimanyu9838 singhabhimanyu9838 commented Dec 21, 2025

Copy link
Copy Markdown

This PR adds a responsive footer to the landing page to improve navigation
and accessibility.

Includes:

  • Project information section
  • Resource links (GitHub, Docs, Contribute)
  • Community link (Discord)
  • Responsive and accessible layout

Related to UI improvement.
Screenshot 2025-12-22 024908

Fixes #816

Summary by CodeRabbit

Release Notes

  • New Features
    • Enhanced footer with Resources section (GitHub, Documentation, Contribute links)
    • Added Community section with Discord link
    • Improved accessibility with ARIA labels
    • Updated copyright display with dynamic year
    • Redesigned footer layout with improved styling and responsive design

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 21, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The Footer component was refactored to remove React.FC type annotation and restructured with expanded content including new Resources and Community sections, additional FontAwesome icon imports, accessibility improvements via ARIA labels, and dynamic year rendering using Tailwind CSS styling.

Changes

Cohort / File(s) Summary
Footer Component Refactoring
landing-page/src/Pages/Footer/Footer.tsx
Removed React.FC type annotation, expanded footer layout with Resources section (GitHub, Documentation, Contribute links), Community section (Discord link), Bottom Bar with dynamic year and "Made with love" text, added FontAwesome icon imports (FaDiscord, FaGithub, FaBook, FaHandsHelping), improved accessibility with ARIA labels, and restructured with Tailwind-based responsive styling

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify all new icon imports are correctly referenced and rendered
  • Confirm responsive flexbox layout works across viewport sizes
  • Review accessibility attributes (aria-label) for completeness and proper semantic structure
  • Check dynamic year calculation (new Date().getFullYear()) functions correctly

Poem

🐰 A footer, once sparse, now blooms with care,
With Discord links floating in the air!
GitHub and docs now have their place,
Made with love—the footer's new grace. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding an informative footer to the landing page. The change summary confirms substantial footer expansion with new sections, resources, and accessibility improvements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ No issue was linked in the PR description.
Please make sure to link an issue (e.g., 'Fixes #issue_number')

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ No issue was linked in the PR description.
Please make sure to link an issue (e.g., 'Fixes #issue_number')

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
landing-page/src/Pages/Footer/Footer.tsx (1)

16-25: Consider: Link to "/" on landing page.

The "PictoPy" link navigates to "/" which may reload the landing page itself. If this footer is reused across multiple pages, this is appropriate. Otherwise, you might consider making it non-clickable on the landing page or using a scroll-to-top behavior.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d07d817 and 67cbdee.

📒 Files selected for processing (1)
  • landing-page/src/Pages/Footer/Footer.tsx (1 hunks)
🔇 Additional comments (5)
landing-page/src/Pages/Footer/Footer.tsx (5)

1-2: LGTM! Imports are appropriate.

The imports are well-chosen: Link for internal navigation and specific FontAwesome icons from react-icons for visual enhancement. All imports are used within the component.


4-4: Good practice: removing React.FC type annotation.

Removing React.FC aligns with modern React best practices. TypeScript correctly infers the return type, and this approach avoids the implicit children prop that React.FC adds.


6-9: Excellent accessibility with semantic HTML.

The footer uses semantic HTML5 <footer> element with an appropriate aria-label, enhancing accessibility for screen readers.


37-68: Proper security attributes on external links.

All external links correctly include rel="noopener noreferrer" with target="_blank", preventing security vulnerabilities and following best practices.


89-96: Well-implemented bottom bar with dynamic year.

The copyright notice correctly uses new Date().getFullYear() for automatic year updates, and the layout is responsive with appropriate styling.

Comment thread landing-page/src/Pages/Footer/Footer.tsx
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ No issue was linked in the PR description.
Please make sure to link an issue (e.g., 'Fixes #issue_number')

PictoPy
</Link>
<p className="text-sm text-gray-400">
AI-powered, privacy-first photo management application with smart

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description “AI-powered” feels a bit vague and potentially misleading. Since PictoPy explicitly uses YOLO, FaceNet, and offline ML pipelines and nothing including AI components and features

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change can be something like this:

Privacy-first photo management with offline object detection, face recognition, and smart tagging.

@akshajtiwari akshajtiwari left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new footer layout and resource links are a nice improvement. I left a couple of comments around wording (“AI-powered”) and the Discord link behavior for new users, but nothing blocking.

<div className="space-y-2">
<p className="text-sm font-semibold text-gray-300">Community</p>
<a
href="https://discord.com/channels/1022871757289422898/1311271974630330388"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
href="https://discord.com/channels/1022871757289422898/1311271974630330388"
href="https://discord.gg/x5bDqCNG"

Even though the channel URL points directly to PictoPy, (discord.com/channels/... )only works for existing members. For a public footer link, we should use a Discord invite link so new users can actually join the server, then navigate to the PictoPy channel.

PictoPy
</Link>
<p className="text-sm text-gray-400">
AI-powered, privacy-first photo management application with smart

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change can be something like this:

Privacy-first photo management with offline object detection, face recognition, and smart tagging.

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR has merge conflicts.

Please resolve the merge conflicts before review.

Your PR will only be reviewed by a maintainer after all conflicts have been resolved.

📺 Watch this video to understand why conflicts occur and how to resolve them:
https://www.youtube.com/watch?v=Sqsz1-o7nXk

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR still has unresolved merge conflicts and has been inactive for the past 30 days.

The PR has merge conflicts label is still applied, and there has been no recent activity on this PR.

Please resolve the merge conflicts or leave a comment if you are still actively working on it.

If there is no further activity within the next 5 days, this PR may be automatically closed to help keep the PR backlog manageable.

@github-actions

Copy link
Copy Markdown
Contributor

🔒 Closing this PR due to unresolved merge conflicts and prolonged inactivity.

This PR still had unresolved merge conflicts, and there was no activity within 5 days of the stale warning being posted.

You may reopen this PR or submit a new one after resolving the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants