UI: add informative footer to landing page#816
Conversation
WalkthroughThe Footer component was refactored to remove React.FC type annotation and restructured with expanded content including new Resources and Community sections, additional FontAwesome icon imports, accessibility improvements via ARIA labels, and dynamic year rendering using Tailwind CSS styling. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
1 similar comment
|
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
landing-page/src/Pages/Footer/Footer.tsx (1)
16-25: Consider: Link to "/" on landing page.The "PictoPy" link navigates to "/" which may reload the landing page itself. If this footer is reused across multiple pages, this is appropriate. Otherwise, you might consider making it non-clickable on the landing page or using a scroll-to-top behavior.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
landing-page/src/Pages/Footer/Footer.tsx(1 hunks)
🔇 Additional comments (5)
landing-page/src/Pages/Footer/Footer.tsx (5)
1-2: LGTM! Imports are appropriate.The imports are well-chosen:
Linkfor internal navigation and specific FontAwesome icons fromreact-iconsfor visual enhancement. All imports are used within the component.
4-4: Good practice: removing React.FC type annotation.Removing
React.FCaligns with modern React best practices. TypeScript correctly infers the return type, and this approach avoids the implicitchildrenprop that React.FC adds.
6-9: Excellent accessibility with semantic HTML.The footer uses semantic HTML5
<footer>element with an appropriatearia-label, enhancing accessibility for screen readers.
37-68: Proper security attributes on external links.All external links correctly include
rel="noopener noreferrer"withtarget="_blank", preventing security vulnerabilities and following best practices.
89-96: Well-implemented bottom bar with dynamic year.The copyright notice correctly uses
new Date().getFullYear()for automatic year updates, and the layout is responsive with appropriate styling.
|
|
| PictoPy | ||
| </Link> | ||
| <p className="text-sm text-gray-400"> | ||
| AI-powered, privacy-first photo management application with smart |
There was a problem hiding this comment.
The description “AI-powered” feels a bit vague and potentially misleading. Since PictoPy explicitly uses YOLO, FaceNet, and offline ML pipelines and nothing including AI components and features
There was a problem hiding this comment.
Suggested change can be something like this:
Privacy-first photo management with offline object detection, face recognition, and smart tagging.
akshajtiwari
left a comment
There was a problem hiding this comment.
The new footer layout and resource links are a nice improvement. I left a couple of comments around wording (“AI-powered”) and the Discord link behavior for new users, but nothing blocking.
| <div className="space-y-2"> | ||
| <p className="text-sm font-semibold text-gray-300">Community</p> | ||
| <a | ||
| href="https://discord.com/channels/1022871757289422898/1311271974630330388" |
There was a problem hiding this comment.
| href="https://discord.com/channels/1022871757289422898/1311271974630330388" | |
| href="https://discord.gg/x5bDqCNG" |
Even though the channel URL points directly to PictoPy, (discord.com/channels/... )only works for existing members. For a public footer link, we should use a Discord invite link so new users can actually join the server, then navigate to the PictoPy channel.
| PictoPy | ||
| </Link> | ||
| <p className="text-sm text-gray-400"> | ||
| AI-powered, privacy-first photo management application with smart |
There was a problem hiding this comment.
Suggested change can be something like this:
Privacy-first photo management with offline object detection, face recognition, and smart tagging.
|
Please resolve the merge conflicts before review. Your PR will only be reviewed by a maintainer after all conflicts have been resolved. 📺 Watch this video to understand why conflicts occur and how to resolve them: |
|
The Please resolve the merge conflicts or leave a comment if you are still actively working on it. If there is no further activity within the next 5 days, this PR may be automatically closed to help keep the PR backlog manageable. |
|
🔒 Closing this PR due to unresolved merge conflicts and prolonged inactivity. This PR still had unresolved merge conflicts, and there was no activity within 5 days of the stale warning being posted. You may reopen this PR or submit a new one after resolving the merge conflicts. |
This PR adds a responsive footer to the landing page to improve navigation
and accessibility.
Includes:
Related to UI improvement.

Fixes #816
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.