fix: Remove duplicate logger initialization in images.py#821
Open
Sanskriti0805 wants to merge 2 commits into
Open
fix: Remove duplicate logger initialization in images.py#821Sanskriti0805 wants to merge 2 commits into
Sanskriti0805 wants to merge 2 commits into
Conversation
- Remove duplicate logger initialization on line 29 - Remove unused 'import logging' statement - Keep only the correct logger initialization using get_logger() Fixes: Duplicate logger initialization causing custom logger to be overwritten Impact: Ensures consistent logging behavior with proper formatting and configuration
Contributor
WalkthroughA single file fix that removes duplicate logger initialization and an unused logging import from the images utility module, retaining only the project's custom logger implementation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Remove Duplicate Logger Initialization in
images.pyDescription
Fixes duplicate logger initialization in
backend/app/utils/images.pythat was causing the custom configured logger to be overwritten by a standard Python logger.Changes Made
logger = logging.getLogger(__name__))import loggingstatementget_logger(__name__)Problem
The logger was initialized twice:
logger = get_logger(__name__)(Correct - uses custom logger)logger = logging.getLogger(__name__)(Duplicate - overwrites custom logger)This caused:
Solution
get_logger()functionTesting
Impact
Closes #815 issue
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.