Add parseDotInt by IvanGoncharov · Pull Request #24 · APIs-guru/dotviz

IvanGoncharov · 2026-05-17T22:18:47Z

No description provided.

gemini-code-assist

Code Review

This pull request updates the workflow documentation in AGENTS.md and introduces a new utility function, parseDotInt, to handle integer parsing for Graphviz attributes. In src/viz.ts, the linelength attribute parsing was updated to use this new utility. Feedback identifies that the parseDotInt regex incorrectly allows decimal values, which contradicts its intended use for strict integers. Furthermore, a regression was noted in src/viz.ts where the validation check was weakened from Number.isInteger to Number.isNaN, potentially allowing invalid non-integer values to be accepted.

Copilot

Pull request overview

Adds a new utility helper (parseDotInt) and switches Viz’s linelength attribute parsing to use it, aiming to validate numeric DOT attribute values more strictly/consistently.

Changes:

Import and use parseDotInt when parsing linelength in src/viz.ts.
Add parseDotInt (with a numeric regex gate) to src/utils.ts.
Strengthen workflow instructions in AGENTS.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`src/viz.ts`	Uses `parseDotInt` for `linelength` parsing and adjusts validation logic.
`src/utils.ts`	Adds `parseDotInt` and a regex intended to constrain numeric parsing.
`AGENTS.md`	Adds a “mandatory workflow” emphasis note to agent guidelines.

Comments suppressed due to low confidence (1)

src/viz.ts:265

The new linelength validation no longer enforces that the parsed value is an integer: isMaxLineLength only range-checks, so values like 60.5 will pass and be forwarded to the backend even though the error message (and existing behavior) says linelength must be an integer. Keep an explicit integer check here (or make parseDotInt reject non-integer forms such as 60.0/60.5) before accepting the value.

      const number = NormalizedAttributes.isText(linelengthValue)
        ? parseDotInt(linelengthValue.text)
        : Number.NaN;
      if (Number.isNaN(number) || !isMaxLineLength(number)) {
        return failureResult([

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

IvanGoncharov · 2026-05-17T23:11:15Z

/gemini review

gemini-code-assist

Code Review

This pull request updates the workflow documentation in AGENTS.md to emphasize that all steps are mandatory and introduces a parseDotNumber utility in src/utils.ts for parsing Graphviz numeric attributes. The utility is integrated into src/viz.ts to handle the linelength attribute. Feedback was provided regarding the parseDotNumber regex, which currently fails to account for valid DOT numerals with leading or trailing decimal points, along with a suggestion to align the implementation with the Graphviz specification.

gemini-code-assist · 2026-05-17T23:12:26Z

+const DOT_NUMBER_RE = /^-?\d+(\.\d+)?$/;
+export function parseDotNumber(value: string): number {
+  return DOT_NUMBER_RE.test(value) ? Number(value) : Number.NaN;
+}


The implementation name parseDotNumber and its support for decimal points in the regex contradict the pull request title Add parseDotInt.

Furthermore, the regex /^-?\d+(\.\d+)?$/ does not account for all valid DOT numerals. According to the Graphviz specification, a numeral can have a leading or trailing decimal point (e.g., .5 or 5.).

If this function is intended to be a general-purpose DOT numeral parser, I recommend updating the regex to be spec-compliant. If it is specifically for integers, it should be renamed to parseDotInt and the regex simplified to /^-?\d+$/.

Suggested change

const DOT_NUMBER_RE = /^-?\d+(\.\d+)?$/;

export function parseDotNumber(value: string): number {

return DOT_NUMBER_RE.test(value) ? Number(value) : Number.NaN;

}

const DOT_NUMBER_RE = /^-?(?:\d+(?:\.\d*)?|\.\d+)$/;

export function parseDotNumber(value: string): number {

return DOT_NUMBER_RE.test(value) ? Number(value) : Number.NaN;

}

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

IvanGoncharov · 2026-05-18T21:19:08Z

/gemini review

gemini-code-assist

Code Review

This pull request updates the workflow documentation to emphasize mandatory steps and introduces a parseDotNumber utility for more robust parsing of Graphviz attributes. A critical logic error was identified in the regular expression used for number parsing, which could allow partial matches and invalid strings to be accepted; a fix was suggested to correctly group the alternation and support trailing decimal points.

gemini-code-assist · 2026-05-18T21:21:11Z

    .slice(1, -1);
 }
+
+const DOT_NUMBER_RE = /^-?\d+(\.\d+)?|-?\.\d+$/;


The DOT_NUMBER_RE regular expression has a logic error because the alternation (|) is not grouped, causing the anchors (^ and $) to only apply to one side of the OR. This allows partial matches (e.g., "123abc" or "abc.123") to pass the test. Additionally, to align with the project's parser and the Graphviz specification, it should support trailing decimal points like 123.. Note that while the PR title mentions parseDotInt, this implementation correctly provides a more general parseDotNumber utility.

Suggested change

const DOT_NUMBER_RE = /^-?\d+(\.\d+)?|-?\.\d+$/;

const DOT_NUMBER_RE = /^-?(\.\d+|\d+(\.\d*)?)$/;

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/utils.ts:12

The PR title suggests adding parseDotInt, but this change introduces parseDotNumber and uses it for linelength (an integer-only attribute). If the intent is specifically integer parsing/validation, consider renaming to parseDotInt (or adding a dedicated parseDotInt wrapper) to match the stated goal and make call sites clearer.

const DOT_NUMBER_RE = /^-?\d+(\.\d+)?|-?\.\d+$/;
export function parseDotNumber(value: string): number {
  return DOT_NUMBER_RE.test(value) ? Number(value) : Number.NaN;
}

IvanGoncharov · 2026-05-18T21:50:20Z

/gemini review

gemini-code-assist

Code Review

This pull request updates the workflow documentation in AGENTS.md, introduces a parseDotNumber utility for DOT-specific number parsing, and applies it to linelength validation in Viz. It also moves ESLint directives within parser.ts and expands test coverage for invalid linelength values. Review feedback identifies that the new regex for number parsing fails to account for valid trailing decimal points and suggests that moving the ESLint directives into individual methods creates redundancy and inconsistency.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/parser.ts:171

Same as above: this /* eslint-disable unicorn/prefer-code-point */ directive is not scoped to the method and will keep the rule disabled beyond this point unless explicitly re-enabled. Prefer eslint-disable-next-line on the charCodeAt statement or re-enable immediately after.

  #peekChar(): number {
    // To make parser internally consistent, all characters are read as UTF-16:
    /* eslint-disable unicorn/prefer-code-point */
    return this.#dotStr.charCodeAt(this.#nextIndex);

IvanGoncharov · 2026-05-26T22:42:35Z

/gemini review

gemini-code-assist

Code Review

This pull request updates the workflow guidelines in AGENTS.md, refactors ESLint disable comments in src/parser.ts, and introduces a parseDotNumber utility to safely parse numeric values from DOT attributes, accompanied by expanded test coverage for invalid linelength values. The reviewer feedback suggests keeping the file-level ESLint disable comment to avoid repetitive method-level disables, and moving parseDotNumber to src/parser.ts to prevent a circular dependency between src/parser.ts and src/utils.ts.

gemini-code-assist · 2026-05-26T22:44:03Z


-// To make parser internally consistent, all characters are read as UTF-16:
-/* eslint-disable unicorn/prefer-code-point */
-
 const Char = {


Restoring the file-level eslint-disable comment is cleaner and avoids ESLint errors in other methods like #peekAheadChar which also use charCodeAt but were missed in this PR.

Suggested change

// To make parser internally consistent, all characters are read as UTF-16:

/* eslint-disable unicorn/prefer-code-point */

const Char = {

// To make parser internally consistent, all characters are read as UTF-16:

/* eslint-disable unicorn/prefer-code-point */

const Char = {

gemini-code-assist · 2026-05-26T22:44:03Z

  #readChar(): number {
+    // To make parser internally consistent, all characters are read as UTF-16:
+    /* eslint-disable unicorn/prefer-code-point */
    return this.#dotStr.charCodeAt(this.#nextIndex++);
  }

  #peekChar(): number {
+    // To make parser internally consistent, all characters are read as UTF-16:
+    /* eslint-disable unicorn/prefer-code-point */
    return this.#dotStr.charCodeAt(this.#nextIndex);
  }


With the file-level eslint-disable restored, these repetitive method-level disables can be removed.

#readChar(): number { return this.#dotStr.charCodeAt(this.#nextIndex++); } #peekChar(): number { return this.#dotStr.charCodeAt(this.#nextIndex); }

gemini-code-assist · 2026-05-26T22:44:03Z

+export function isNumberToken(str: string): boolean {
+  const lexer = new Lexer(str);
+  const token = lexer.nextToken();
+  return token.kind === Kind.Number && token.length === str.length;
+}


Moving parseDotNumber to src/parser.ts next to isNumberToken avoids a circular dependency between src/parser.ts and src/utils.ts.

Suggested change

export function isNumberToken(str: string): boolean {

const lexer = new Lexer(str);

const token = lexer.nextToken();

return token.kind === Kind.Number && token.length === str.length;

}

export function isNumberToken(str: string): boolean {

const lexer = new Lexer(str);

const token = lexer.nextToken();

return token.kind === Kind.Number && token.length === str.length;

}

export function parseDotNumber(value: NormalizedAttributeValue): number {

return NormalizedAttributes.isText(value) && isNumberToken(value.text)

? Number.parseFloat(value.text)

: Number.NaN;

}

gemini-code-assist · 2026-05-26T22:44:03Z

+import {
+  NormalizedAttributes,
+  type NormalizedAttributeValue,
+} from './normalize-graph.ts';
+import { isNumberToken } from './parser.ts';


These imports are no longer needed once parseDotNumber is moved to src/parser.ts.

gemini-code-assist · 2026-05-26T22:44:03Z

+export function parseDotNumber(value: NormalizedAttributeValue): number {
+  return NormalizedAttributes.isText(value) && isNumberToken(value.text)
+    ? Number.parseFloat(value.text)
+    : Number.NaN;
+}


Removing parseDotNumber from src/utils.ts as it has been moved to src/parser.ts to resolve the circular dependency.

gemini-code-assist · 2026-05-26T22:44:04Z

 import { parseDot } from './parser.ts';
-import { formatValueForDiagnostics } from './utils.ts';
+import { formatValueForDiagnostics, parseDotNumber } from './utils.ts';


Import parseDotNumber from ./parser.ts instead of ./utils.ts to align with the move and avoid circular dependencies.

Suggested change

import { parseDot } from './parser.ts';

import { formatValueForDiagnostics } from './utils.ts';

import { formatValueForDiagnostics, parseDotNumber } from './utils.ts';

import { parseDot, parseDotNumber } from './parser.ts';

import { formatValueForDiagnostics } from './utils.ts';

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


  #readChar(): number {
+    // To make parser internally consistent, all characters are read as UTF-16:
+    /* eslint-disable unicorn/prefer-code-point */


+    /* eslint-disable unicorn/prefer-code-point */
    return this.#dotStr.charCodeAt(this.#nextIndex++);
  }

  #peekChar(): number {
+    // To make parser internally consistent, all characters are read as UTF-16:
+    /* eslint-disable unicorn/prefer-code-point */


Copilot AI review requested due to automatic review settings May 17, 2026 22:18

Copilot started reviewing on behalf of IvanGoncharov May 17, 2026 22:19 View session

gemini-code-assist Bot reviewed May 17, 2026

View reviewed changes

Comment thread src/utils.ts Outdated

Comment thread src/viz.ts Outdated

Copilot AI reviewed May 17, 2026

View reviewed changes

Comment thread src/utils.ts Outdated

Comment thread src/viz.ts Outdated

IvanGoncharov force-pushed the pr_branch branch from 472d2b2 to 00831ab Compare May 17, 2026 23:10

IvanGoncharov requested a review from Copilot May 17, 2026 23:11

Copilot started reviewing on behalf of IvanGoncharov May 17, 2026 23:11 View session

gemini-code-assist Bot reviewed May 17, 2026

View reviewed changes

Copilot AI reviewed May 17, 2026

View reviewed changes

Comment thread src/utils.ts Outdated

IvanGoncharov force-pushed the pr_branch branch from 00831ab to 11760ab Compare May 18, 2026 21:18

IvanGoncharov requested a review from Copilot May 18, 2026 21:18

Copilot started reviewing on behalf of IvanGoncharov May 18, 2026 21:19 View session

gemini-code-assist Bot reviewed May 18, 2026

View reviewed changes

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread src/utils.ts Outdated

Comment thread src/viz.ts

IvanGoncharov force-pushed the pr_branch branch from 11760ab to f9c1cd4 Compare May 18, 2026 21:49

IvanGoncharov requested a review from Copilot May 18, 2026 21:50

Copilot started reviewing on behalf of IvanGoncharov May 18, 2026 21:50 View session

gemini-code-assist Bot reviewed May 18, 2026

View reviewed changes

Comment thread src/utils.ts Outdated

Comment thread src/parser.ts

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread test/render.test.ts

Comment thread src/parser.ts

Comment thread src/utils.ts Outdated

Add parseDotInt

ab5d1b7

IvanGoncharov force-pushed the pr_branch branch from f9c1cd4 to ab5d1b7 Compare May 26, 2026 22:41

IvanGoncharov requested a review from Copilot May 26, 2026 22:42

Copilot started reviewing on behalf of IvanGoncharov May 26, 2026 22:42 View session

gemini-code-assist Bot reviewed May 26, 2026

View reviewed changes

Copilot AI reviewed May 26, 2026

View reviewed changes

IvanGoncharov merged commit 428e3b8 into main May 26, 2026
2 checks passed

IvanGoncharov deleted the pr_branch branch May 26, 2026 22:57

	const DOT_NUMBER_RE = /^-?\d+(\.\d+)?\|-?\.\d+$/;
	const DOT_NUMBER_RE = /^-?(\.\d+\|\d+(\.\d*)?)$/;

Conversation

IvanGoncharov commented May 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

IvanGoncharov commented May 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

IvanGoncharov commented May 18, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

IvanGoncharov commented May 18, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IvanGoncharov commented May 26, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 26, 2026

Choose a reason for hiding this comment