Fix pyproject.toml: move dependencies key out of [project.urls] - #2
Merged
Conversation
PyYAML>=6 was declared under [project.urls], where PEP 621 requires string values. Hatchling 1.32 rejects it, so metadata generation fails for pip install ., pip install -e ".[dev]", and python -m build. Moving it to [project] fixes the build and registers PyYAML as the runtime dependency it is (llmism/_patterns.py imports yaml at import). Fixes #1 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
frankreyesgarcia
force-pushed
the
fix/pyproject-dependencies-key
branch
from
September 10, 2026 12:06
b5c52d2 to
06b9573
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change directly addresses the reported PEP 621/Hatchling error with a minimal, correct adjustment to pyproject.toml and introduces no additional risk.
Pull request overview
This PR fixes the Python packaging metadata by moving dependencies out of [project.urls] and into the correct [project] table per PEP 621, resolving Hatchling metadata generation failures and correctly declaring PyYAML as a runtime dependency.
Changes:
- Add
dependencies = ["PyYAML>=6"]under[project]. - Remove the invalid
dependenciesentry from[project.urls].
File summaries
| File | Description |
|---|---|
| pyproject.toml | Corrects PEP 621 table usage so metadata generation succeeds and PyYAML is declared as a runtime dependency. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyYAML>=6was declared inside the[project.urls]table, where PEP 621 requires string values. Hatchling 1.32 rejects it, so metadata generation fails for every install path:all with:
This one-line move puts
dependenciesin the[project]table where it belongs. It also makesPyYAMLan actual declared runtime dependency, which it needs to be:llmism/_patterns.pyimportsyamlat module load.Verified: after the change,
pip install .succeeds in a clean venv andimport llmism, yamlworks.Fixes #1