Open
Conversation
Open
3 tasks
sonms
approved these changes
May 11, 2025
| ) : AuthRepository { | ||
|
|
||
| override suspend fun signUp(signUpData: SignUpEntity): Result<SignUpUserEntity> = | ||
| runCatching { |
Member
There was a problem hiding this comment.
Try catch 문으로 사용했었는데 runCatching으로 체이닝이 깔끔하게 이뤄지네요 하나 배워갑니다!
There was a problem hiding this comment.
저도 현재 화면에서 try-catch 방식으로 예외 처리를 하고 있는데요, 예인님처럼 runCatching을 쓰면 비동기 체이닝이 더 깔끔해 보이네용 .ᐟ
혹시 팀에서 선호하는 방식이 따로 있나요, 아니면 상황에 따라 자유롭게 쓰면 될까요?
| override fun intercept(chain: Interceptor.Chain): Response { | ||
| val request = chain.request() | ||
| val builder = request.newBuilder() | ||
| val authType = request.tag(AuthType::class.java) ?: AuthType.TOKEN |
JiWoo1261
approved these changes
May 13, 2025
| ) : AuthRepository { | ||
|
|
||
| override suspend fun signUp(signUpData: SignUpEntity): Result<SignUpUserEntity> = | ||
| runCatching { |
There was a problem hiding this comment.
저도 현재 화면에서 try-catch 방식으로 예외 처리를 하고 있는데요, 예인님처럼 runCatching을 쓰면 비동기 체이닝이 더 깔끔해 보이네용 .ᐟ
혹시 팀에서 선호하는 방식이 따로 있나요, 아니면 상황에 따라 자유롭게 쓰면 될까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
🌱 작업한 내용
🌱 PR 포인트
📸 스크린샷
default.mp4
default.mp4
default.mp4
📮 관련 이슈
#7