Skip to content

[cuegui] Fix preview frames error#2389

Merged
ramonfigueiredo merged 2 commits into
AcademySoftwareFoundation:masterfrom
ramonfigueiredo:cuegui-fix-preview-bytes-decode
Jun 3, 2026
Merged

[cuegui] Fix preview frames error#2389
ramonfigueiredo merged 2 commits into
AcademySoftwareFoundation:masterfrom
ramonfigueiredo:cuegui-fix-preview-bytes-decode

Conversation

@ramonfigueiredo

@ramonfigueiredo ramonfigueiredo commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Related Issues

Summarize your change.

  • Decode HTTP playlist response to str
  • Fixes "write() argument must be str, not bytes" Preview Error

- Decode HTTP playlist response to str
- Fixes "write() argument must be str, not bytes" Preview Error
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The PreviewProcessorDialog.process() method now decodes the HTTP response body to UTF-8 text before passing it to XML parsing, changing from raw bytes to a string input type.

Changes

HTTP Response Decoding

Layer / File(s) Summary
HTTP Response Decoding for XML Parsing
cuegui/cuegui/PreviewWidget.py
The preview server response body is decoded from bytes to UTF-8 string via .decode('utf-8'), ensuring the subsequent XML parser receives a properly formatted string input.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

A single byte was changed with care,
From raw bytes floating through the air,
Now UTF-8 strings dance with glee,
The XML parser reads happily! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly relates to the main change: fixing a preview frames error by decoding the HTTP response from bytes to UTF-8 string to resolve a write() argument type error.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ramonfigueiredo ramonfigueiredo self-assigned this Jun 3, 2026
@ramonfigueiredo ramonfigueiredo merged commit a1a1518 into AcademySoftwareFoundation:master Jun 3, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants