[rqd] Fix rqd recovery mode - #2503
Draft
DiegoTavares wants to merge 1 commit into
Draft
Conversation
Recover mode was never working properly on Linux as when running as under systemctl service, spawned frames were being killed with the rqd process for both belong to the same cgroup. This change not only changes the .service default `KillMode=control-group` to `KillMode=process` but also fixes a bug on the frames hardness: - frame_cmd.rs — enabled the exit-file harness on Linux and rewrote the wrapper script, which had real bugs: command_pid=$! was captured after a foreground eval (so it was always empty), the trap wrote the raw signal number as the exit code, and bash defers traps while a foreground child runs (kills couldn't be forwarded). The new script runs the command in the background + wait, forwards signals, re-waits until the command truly exits, and writes the exit file atomically (tmp + mv).
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recover mode was never working properly on Linux as when running as under systemctl service, spawned frames were being killed with the rqd process for both belong to the same cgroup.
This change not only changes the .service default
KillMode=control-grouptoKillMode=processbut also fixes a bug on the frames hardness:LLM usage disclosure
Claude Opus was used to execute the changes on this PR.