Update SonarCloud job to install latest sonar-scanner and build-wrapper using a github action#1401
Update SonarCloud job to install latest sonar-scanner and build-wrapper using a github action#1401xlietz wants to merge 1 commit into
Conversation
|
|
||
| on: | ||
| schedule: | ||
| # schedule: |
There was a problem hiding this comment.
Is there a reason to leave this in but commented out? This change means the analysis will run on each pull request, not just weekly, right? Seems ok to give that a try at least.
There was a problem hiding this comment.
Yes this pull request wasn't ready to merge - I had just issued it to try to test this workflow which is why I commented out the schedule, I was hoping it would run upon pull request. But it didn't seem to work so I still need to try pushing a separate branch temporarily.
|
@xlietz, does this seem to resolve the issues? Good to go? |
|
@cary-ilm I'm still testing this - I will leave a comment when it's ready. Thanks! |
xlietz
force-pushed
the
sonarcloud-update
branch
4 times, most recently
from
c920e36 to
fd63a4d
Compare
build-wrapper. Signed-off-by: Christina Tempelaar-Lietz <xlietz@gmail.com>
|
@xlietz, this went stale but I think it's all gotten worked out. OK to close this? |
2 participants
NOTE: Not ready for review - still testing this PR! I submitted this to test my changes since the Sonar scan has to be run on the ASWF repo to work properly.
Updating the SonarCloud job to get the latest sonar-scanner and build-wrapper by using a github action instead of using the versions in the docker image. @cary-ilm noticed that the SonarCloud analysis is generating a warning that the build wrapper version does not match the analyzer version.