Skip to content

docs: add openexr_enable_threading to install.rst cmake options#2353

Open
nitzan-treg wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
nitzan-treg:fix/2351-document-enable-threading-option
Open

docs: add openexr_enable_threading to install.rst cmake options#2353
nitzan-treg wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
nitzan-treg:fix/2351-document-enable-threading-option

Conversation

@nitzan-treg

Copy link
Copy Markdown

hey, saw #2351 — the threading cmake option wasnt listed in the component options section on install.rst so added an entry for it.

kept the wording short and matching the format of the other entries (force_embedded_core, build_testing, etc). verified in cmake/OpenEXRSetup.cmake that the option exists with default ON and is used to gate the threading library lookup.

placed it right after force_embedded_core since both are core library behaviour options.

fixes #2351

saw AcademySoftwareFoundation#2351, the threading cmake option wasnt listed alongside the other component options so added an entry under component options right after force_embedded_core. kept the wording short and matching the style of the other entries.
@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

@cary-ilm

Copy link
Copy Markdown
Member

This looks great, thanks!

Our project policy requires a signed Contributor License Agreement. Can you click on the red "SIGNED AGREEMENT MISSING" button above and sign the required forms?

Also, we require a Developer Certificate of Origin (DCO), or "signed commits", via commit -s. Can you amend your commit this way:

git commit -s --amend --no-edit
git push --force

That will add the "signed-off-by" statement. It won't work to simply add a second commit because each commit needs the signature, hence the need for the --amend and git push --force.

@cary-ilm

Copy link
Copy Markdown
Member

@nitzan-treg, I'd like to accept this, will you be able to complete the CLA and DCO?

@cary-ilm

Copy link
Copy Markdown
Member

@nitzan-treg, one more try, will you be able to sign the required forms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

website documentation should mention OPENEXR_ENABLE_THREADING

2 participants