docs: add openexr_enable_threading to install.rst cmake options#2353
Open
nitzan-treg wants to merge 1 commit into
Open
Conversation
saw AcademySoftwareFoundation#2351, the threading cmake option wasnt listed alongside the other component options so added an entry under component options right after force_embedded_core. kept the wording short and matching the style of the other entries.
|
Member
|
This looks great, thanks! Our project policy requires a signed Contributor License Agreement. Can you click on the red "SIGNED AGREEMENT MISSING" button above and sign the required forms? Also, we require a Developer Certificate of Origin (DCO), or "signed commits", via That will add the "signed-off-by" statement. It won't work to simply add a second commit because each commit needs the signature, hence the need for the |
Member
|
@nitzan-treg, I'd like to accept this, will you be able to complete the CLA and DCO? |
Member
|
@nitzan-treg, one more try, will you be able to sign the required forms? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey, saw #2351 — the threading cmake option wasnt listed in the component options section on install.rst so added an entry for it.
kept the wording short and matching the format of the other entries (force_embedded_core, build_testing, etc). verified in cmake/OpenEXRSetup.cmake that the option exists with default ON and is used to gate the threading library lookup.
placed it right after force_embedded_core since both are core library behaviour options.
fixes #2351