Add support for lossy HTJ2K compressor#2425
Conversation
|
@Vertexwahn, any suggestion to fix the Bazel failure here? I see two errors in the logs: and:
|
|
And @palemieux, can you amend the commits with |
|
Short time solution: Change in |
|
Once bazelbuild/bazel-central-registry#9032 is merge you can change |
b87f94b to
5011ecd
Compare
|
It might be better to put the |
cary-ilm
left a comment
There was a problem hiding this comment.
Just to confirm, are the changes to the vendored OpenJPH simply from vendoring in 0.27.3? Are there any changes we need to make sure don't get stomped on?
Stock 27.3. No additional changes. Thanks for making sure. |
Ok. Will split it off before the lossy J2K branch is merged. |
|
@peterhillman and @palemieux, since this PR is going into the lossy-htj2k feature branch, the exrmetrics changes can stay here and also go into a separate PR for main. That will highlight them more prominently in the commit history and release notes. |
|
Ok. I can create a PR against main. |
|
@palemieux, I think this is only waiting on @michaeldsmith's comment suggestions? |
|
See #2448 for a standalone PR adding MSE to exrmetrics. |
cary-ilm
left a comment
There was a problem hiding this comment.
A few minor suggestions, otherwise it looks ready to go to me.
41e5f6f to
234b058
Compare
234b058 to
7a41a80
Compare
Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>
Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
* Improve the handling of non-finite samples Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>
7a41a80 to
c50df3b
Compare
Co-authored-by: Cary Phillips <cary@ilm.com> Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Co-authored-by: Cary Phillips <cary@ilm.com> Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Co-authored-by: Cary Phillips <cary@ilm.com> Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Co-authored-by: Cary Phillips <cary@ilm.com> Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Co-authored-by: Cary Phillips <cary@ilm.com> Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Co-authored-by: Cary Phillips <cary@ilm.com> Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
b5efc6c
into
AcademySoftwareFoundation:lossy-htj2k
See https://academysoftwarefdn.slack.com/archives/CMLRW4N73/p1777317753088359