Reject NULL preview rgba data in exr_attr_set_preview()#2469
Open
cary-ilm wants to merge 1 commit into
Open
Conversation
Validate the source rgba pointer before memcpy in exr_attr_preview_create() and the same-dimensions update path in exr_attr_set_preview(), preventing a NULL pointer dereference when nonzero preview dimensions are supplied without pixel data. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Cary Phillips <cary@ilm.com>
kthurston
approved these changes
Jun 17, 2026
kthurston
left a comment
kthurston
left a comment
There was a problem hiding this comment.
FYI: I think that this is the similar to the 0 channel list size issue #2473 - the older code allowed a w or h of 0, with the difference being that this is continuing to handle a 0 size - but if a 0 size should be invalid, we should probably just test the pointer and then change the code in init to fail on w or h == 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the source rgba pointer before memcpy in exr_attr_preview_create() and the same-dimensions update path in exr_attr_set_preview(), preventing a NULL pointer dereference when nonzero preview dimensions are supplied without pixel data.
Addresses https://github.com/AcademySoftwareFoundation/openexr/security/advisories/GHSA-29q6-4p2c-77qq