Fix the DWAA size checks regression#2476
Merged
cary-ilm merged 2 commits intoJun 17, 2026
Merged
Conversation
Signed-off-by: Vlad Lazar <vlazar@ilm.com>
kthurston
approved these changes
Jun 17, 2026
kthurston
left a comment
kthurston
left a comment
There was a problem hiding this comment.
LGTM - yes, that count is a count, not a size and I missed that in the previous fix where I think we fixed up the actual issue exposed separately. Thanks!
Member
but this is the count |
cary-ilm
merged commit bc7fc07
into
AcademySoftwareFoundation:main
50 of 51 checks passed
cary-ilm
pushed a commit
that referenced
this pull request
Jun 17, 2026
peterhillman
pushed a commit
that referenced
this pull request
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced by #2383
I was able to read a DWAA file using RB-3.4 (67de2bf) but not latest main.
The original file was generated with Nuke15.1v5 . I was unable to generate a problematic file synthetically.
From what I can read inside this file is that totalAcUncompressedCount is not a bytecount but rather a "count of uint16 DCT (AC) coefficients/elements,".
It would normally have to multiplied with sizeof(uint16). A similar condition is already enforced here:
openexr/src/lib/OpenEXRCore/internal_dwa_compressor.h
Line 901 in 0565c02
Testing: