Skip to content

Add deps#10

Open
asukaminato0721 wants to merge 2 commits into
ActivityWatch:masterfrom
asukaminato0721:add-deps
Open

Add deps#10
asukaminato0721 wants to merge 2 commits into
ActivityWatch:masterfrom
asukaminato0721:add-deps

Conversation

@asukaminato0721

Copy link
Copy Markdown
Contributor

fix part of #2

@0xbrayo 0xbrayo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErikBjare

Copy link
Copy Markdown
Member

I'm not sure if this is quite right. Since we ship binaries with most of these libraries already included, we actually don't depend on many/most of them being installed.

I also think many of these are transient dependencies, thus shouldn't be explicitly listed in the PKGBUILD.

@0xbrayo

0xbrayo commented Sep 5, 2024

Copy link
Copy Markdown
Member

I guess I could strip the new dependencies, just keep the version bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants