feat: support all existing bid modifiers#9
Open
Adel7418 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /yandex/campaigns/{campaign_id}/bid-modifiersresponse for all bid modifier rows returned by DirectPOST /yandex/campaigns/{campaign_id}/bid-modifiersrequest model from age-only to existing modifier updates bymodifier_idId; no create-new-weather-modifier behavior{Id, BidModifier}only, with existing approval/idempotency/live_write gatesSafety
Verification
uv run pytest -q tests/test_bid_modifiers_update.py tests/test_bid_modifiers_models.py→ 18 passeduv run pytest -q→ 596 passeduv run python scripts/check_openapi_sync.py→ OpenAPI snapshot is in syncuv run python scripts/check_no_secrets_in_git.py→ No obvious tracked secrets detectedNotes
origin/masterto avoid mixing unrelated sitelinks/UTM work from the local dirty checkout._safe_intmore tolerant of signed/whitespace strings and extend modifier type inference if new Direct provider shapes appear.