Skip to content

[transfers] Code generation: update services and models#1786

Open
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/transfers
Open

[transfers] Code generation: update services and models#1786
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/transfers

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the transfers service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested a review from a team as a code owner June 4, 2026 16:09

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames CapitalService and its associated interfaces and events to CapitalDeprecatedService to reflect its deprecation. The feedback points out that in CapitalDeprecatedService.cs, the constructor parameter CapitalDeprecatedServiceEvents is assigned a default value of null but is not marked as nullable, which will trigger a compiler warning under #nullable enable.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

/// Initializes a new instance of the <see cref="CapitalDeprecatedService"/> class.
/// </summary>
public CapitalService(AdyenOptionsProvider adyenOptionsProvider, ILogger<CapitalService> logger, ILoggerFactory loggerFactory, System.Net.Http.HttpClient httpClient, JsonSerializerOptionsProvider jsonSerializerOptionsProvider, ITokenProvider<ApiKeyToken> apiKeyProvider, CapitalServiceEvents capitalServiceEvents = null)
public CapitalDeprecatedService(AdyenOptionsProvider adyenOptionsProvider, ILogger<CapitalDeprecatedService> logger, ILoggerFactory loggerFactory, System.Net.Http.HttpClient httpClient, JsonSerializerOptionsProvider jsonSerializerOptionsProvider, ITokenProvider<ApiKeyToken> apiKeyProvider, CapitalDeprecatedServiceEvents capitalDeprecatedServiceEvents = null)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Under #nullable enable, assigning null as a default value to the non-nullable parameter CapitalDeprecatedServiceEvents will trigger a compiler warning (CS8625). Since the parameter is optional and can be null, it should be marked as nullable (CapitalDeprecatedServiceEvents?).

        public CapitalDeprecatedService(AdyenOptionsProvider adyenOptionsProvider, ILogger<CapitalDeprecatedService> logger, ILoggerFactory loggerFactory, System.Net.Http.HttpClient httpClient, JsonSerializerOptionsProvider jsonSerializerOptionsProvider, ITokenProvider<ApiKeyToken> apiKeyProvider, CapitalDeprecatedServiceEvents? capitalDeprecatedServiceEvents = null)

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transfers branch 4 times, most recently from eda6b5b to e1674cd Compare June 15, 2026 16:42
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transfers branch from e1674cd to f03c1fa Compare June 17, 2026 09:04
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transfers branch 7 times, most recently from d16285d to 974aded Compare June 24, 2026 08:32
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transfers branch 4 times, most recently from fe7470d to c077d06 Compare July 7, 2026 09:20
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transfers branch 6 times, most recently from b37e75a to e71f9d0 Compare July 15, 2026 06:41
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transfers branch from e71f9d0 to 6efd4e7 Compare July 15, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants