[transfers] Code generation: update services and models#1786
[transfers] Code generation: update services and models#1786AdyenAutomationBot wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request renames CapitalService and its associated interfaces and events to CapitalDeprecatedService to reflect its deprecation. The feedback points out that in CapitalDeprecatedService.cs, the constructor parameter CapitalDeprecatedServiceEvents is assigned a default value of null but is not marked as nullable, which will trigger a compiler warning under #nullable enable.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| /// Initializes a new instance of the <see cref="CapitalDeprecatedService"/> class. | ||
| /// </summary> | ||
| public CapitalService(AdyenOptionsProvider adyenOptionsProvider, ILogger<CapitalService> logger, ILoggerFactory loggerFactory, System.Net.Http.HttpClient httpClient, JsonSerializerOptionsProvider jsonSerializerOptionsProvider, ITokenProvider<ApiKeyToken> apiKeyProvider, CapitalServiceEvents capitalServiceEvents = null) | ||
| public CapitalDeprecatedService(AdyenOptionsProvider adyenOptionsProvider, ILogger<CapitalDeprecatedService> logger, ILoggerFactory loggerFactory, System.Net.Http.HttpClient httpClient, JsonSerializerOptionsProvider jsonSerializerOptionsProvider, ITokenProvider<ApiKeyToken> apiKeyProvider, CapitalDeprecatedServiceEvents capitalDeprecatedServiceEvents = null) |
There was a problem hiding this comment.
Under #nullable enable, assigning null as a default value to the non-nullable parameter CapitalDeprecatedServiceEvents will trigger a compiler warning (CS8625). Since the parameter is optional and can be null, it should be marked as nullable (CapitalDeprecatedServiceEvents?).
public CapitalDeprecatedService(AdyenOptionsProvider adyenOptionsProvider, ILogger<CapitalDeprecatedService> logger, ILoggerFactory loggerFactory, System.Net.Http.HttpClient httpClient, JsonSerializerOptionsProvider jsonSerializerOptionsProvider, ITokenProvider<ApiKeyToken> apiKeyProvider, CapitalDeprecatedServiceEvents? capitalDeprecatedServiceEvents = null)eda6b5b to
e1674cd
Compare
e1674cd to
f03c1fa
Compare
d16285d to
974aded
Compare
fe7470d to
c077d06
Compare
b37e75a to
e71f9d0
Compare
e71f9d0 to
6efd4e7
Compare
This PR contains the automated changes for the
transfersservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.