[transferwebhooks] Code generation: update services and models#1827
[transferwebhooks] Code generation: update services and models#1827AdyenAutomationBot wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces tracing data models (UKFpsTracingData, USAchTracingData, TransferDataTracing, TransferEventTracingData, and NetworkReason) and registers their JSON converters to support UK FPS and US ACH network tracing. It also removes deprecated advice statuses from several models. The review feedback highlights that the required discriminator Type properties in UKFpsTracingData and USAchTracingData should be initialized by default to prevent serialization failures. Additionally, several auto-generated JSON converters assign nullable strings to non-nullable variables, which triggers CS8600 compiler warnings under #nullable enable and should be resolved.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| /// </summary> | ||
| /// <value>**ukFps**</value> | ||
| [JsonPropertyName("type")] | ||
| public TypeEnum Type { get; set; } |
There was a problem hiding this comment.
The Type property is a required discriminator field but is not initialized by default. When serializing UKFpsTracingData, if the user does not manually set this property, the "type" field will be omitted from the JSON payload, causing deserialization to fail on the receiver's end. It should be initialized to TypeEnum.UkFps by default.
public TypeEnum Type { get; set; } = TypeEnum.UkFps;| /// </summary> | ||
| /// <value>**usAch**</value> | ||
| [JsonPropertyName("type")] | ||
| public TypeEnum Type { get; set; } |
There was a problem hiding this comment.
The Type property is a required discriminator field but is not initialized by default. When serializing USAchTracingData, if the user does not manually set this property, the "type" field will be omitted from the JSON payload, causing deserialization to fail on the receiver's end. It should be initialized to TypeEnum.UsAch by default.
public TypeEnum Type { get; set; } = TypeEnum.UsAch;| /// </summary> | ||
| public override NamespaceEnum? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions jsonOptions) | ||
| { | ||
| string value = reader.GetString(); |
There was a problem hiding this comment.
| /// </summary> | ||
| public override TypeEnum? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions jsonOptions) | ||
| { | ||
| string value = reader.GetString(); |
There was a problem hiding this comment.
| /// <summary> | ||
| /// Deserializes a <see cref="TypeEnum"/> from JSON. | ||
| /// </summary> | ||
| public override TypeEnum? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions jsonOptions) |
There was a problem hiding this comment.
| /// <summary> | ||
| /// Deserializes a <see cref="TypeEnum"/> from JSON. | ||
| /// </summary> | ||
| public override TypeEnum? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions jsonOptions) |
There was a problem hiding this comment.
| /// <summary> | ||
| /// Deserializes a <see cref="TypeEnum"/> from JSON. | ||
| /// </summary> | ||
| public override TypeEnum? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions jsonOptions) |
There was a problem hiding this comment.
e8f21ea to
a9d9d07
Compare
c1fc960 to
a51d0b4
Compare
a51d0b4 to
bf79a52
Compare
This PR contains the automated changes for the
transferwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.