Skip to content

[transferwebhooks] Code generation: update services and models#1827

Open
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/transferwebhooks
Open

[transferwebhooks] Code generation: update services and models#1827
AdyenAutomationBot wants to merge 1 commit into
mainfrom
sdk-automation/transferwebhooks

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the transferwebhooks service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested a review from a team as a code owner July 6, 2026 17:24

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces tracing data models (UKFpsTracingData, USAchTracingData, TransferDataTracing, TransferEventTracingData, and NetworkReason) and registers their JSON converters to support UK FPS and US ACH network tracing. It also removes deprecated advice statuses from several models. The review feedback highlights that the required discriminator Type properties in UKFpsTracingData and USAchTracingData should be initialized by default to prevent serialization failures. Additionally, several auto-generated JSON converters assign nullable strings to non-nullable variables, which triggers CS8600 compiler warnings under #nullable enable and should be resolved.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

/// </summary>
/// <value>**ukFps**</value>
[JsonPropertyName("type")]
public TypeEnum Type { get; set; }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Type property is a required discriminator field but is not initialized by default. When serializing UKFpsTracingData, if the user does not manually set this property, the "type" field will be omitted from the JSON payload, causing deserialization to fail on the receiver's end. It should be initialized to TypeEnum.UkFps by default.

        public TypeEnum Type { get; set; } = TypeEnum.UkFps;

/// </summary>
/// <value>**usAch**</value>
[JsonPropertyName("type")]
public TypeEnum Type { get; set; }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Type property is a required discriminator field but is not initialized by default. When serializing USAchTracingData, if the user does not manually set this property, the "type" field will be omitted from the JSON payload, causing deserialization to fail on the receiver's end. It should be initialized to TypeEnum.UsAch by default.

        public TypeEnum Type { get; set; } = TypeEnum.UsAch;

/// </summary>
public override NamespaceEnum? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions jsonOptions)
{
string value = reader.GetString();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Under #nullable enable, reader.GetString() returns a nullable string (string?). Assigning it to a non-nullable string variable will trigger a compiler warning (CS8600). Change the variable type to string? to make the code warning-free.

                    string? value = reader.GetString();

/// </summary>
public override TypeEnum? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions jsonOptions)
{
string value = reader.GetString();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Under #nullable enable, reader.GetString() returns a nullable string (string?). Assigning it to a non-nullable string variable will trigger a compiler warning (CS8600). Change the variable type to string? to make the code warning-free.

                    string? value = reader.GetString();

/// <summary>
/// Deserializes a <see cref="TypeEnum"/> from JSON.
/// </summary>
public override TypeEnum? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions jsonOptions)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Under #nullable enable, reader.GetString() returns a nullable string (string?). Assigning it to a non-nullable string variable will trigger a compiler warning (CS8600). Change the variable type to string? to make the code warning-free.

                    string? value = reader.GetString();

/// <summary>
/// Deserializes a <see cref="TypeEnum"/> from JSON.
/// </summary>
public override TypeEnum? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions jsonOptions)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Under #nullable enable, reader.GetString() returns a nullable string (string?). Assigning it to a non-nullable string variable will trigger a compiler warning (CS8600). Change the variable type to string? to make the code warning-free.

                    string? value = reader.GetString();

/// <summary>
/// Deserializes a <see cref="TypeEnum"/> from JSON.
/// </summary>
public override TypeEnum? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions jsonOptions)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Under #nullable enable, reader.GetString() returns a nullable string (string?). Assigning it to a non-nullable string variable will trigger a compiler warning (CS8600). Change the variable type to string? to make the code warning-free.

                    string? value = reader.GetString();

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transferwebhooks branch 4 times, most recently from e8f21ea to a9d9d07 Compare July 13, 2026 14:24
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transferwebhooks branch 3 times, most recently from c1fc960 to a51d0b4 Compare July 15, 2026 06:41
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transferwebhooks branch from a51d0b4 to bf79a52 Compare July 15, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant