[ECP-9579] Remove amqp queue connection definitions

[candemiralp]

Description

This PR removes the default connection attribute amqp from queue configuration directives.

Tested scenarios

• DB and RabbitMQ queue processors

Fixes #3247

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to simplify the message queue configuration by removing redundant amqp connection attributes from various XML definition files. By eliminating these explicit declarations, the system will now rely on Magento's default message queue connection settings, leading to cleaner and potentially more maintainable configuration files. This change specifically impacts the adyen.notification queue and its associated publisher and topology.

Highlights

• Queue Configuration Simplification: Explicit amqp connection definitions have been removed from queue_consumer.xml, queue_publisher.xml, and queue_topology.xml files. This change relies on Magento's default message queue connection handling.
• Reduced Redundancy: The removal of these attributes streamlines the configuration, as amqp is often the default or implicitly handled connection type for message queues in Magento.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request simplifies the message queue configuration by removing explicit connection="amqp" attributes from the adyen.notification consumer, publisher, and the magento exchange definition in etc/queue_consumer.xml, etc/queue_publisher.xml, and etc/queue_topology.xml respectively. This change likely streamlines the configuration by relying on default connection settings or a centralized connection definition. No specific feedback was provided in the review comments.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud