[management] Code generation: update services and models

[AdyenAutomationBot]

This PR contains the automated changes for the management service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

Management API

• Add support for AlipayPlusInfo, GivexInfo, MaestroUsa , PayByBankPlaidInfo, SepaDirectDebitInfo, SvsInfo, ValuelinkInfo
• Add Moto to support settings for Mail Order/Telephone Order transactions in TerminalSettings
• Add support for ForceRebootDetails for Terminals schedule actions (ScheduleTerminalActionsRequest)
• Add PricePlanEnum in AffirmInfo
• Add attribute SupportEmail in AfterpayTouchInfo
• Add attribute DomainSuffix in Profile
• Add attribute Unreferenced in Refunds
• In SplitConfigurationRule add attribute CardRegion with enum CardRegionEnum

[gemini-code-assist]

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers automated code updates for the management service, incorporating the latest changes from the adyen-openapi repository. These updates include modifications to existing models, the addition of new models, and improvements to enum handling and documentation, enhancing the functionality and reliability of the Management API.

Highlights

• Code Generation Update: This PR includes automated code generation updates for the management service, reflecting changes in the adyen-openapi repository.
• Model Changes: Several models have been updated, including AccelInfo, AdditionalSettings, AffirmInfo, AmexInfo, Amount, AndroidApp, CardholderReceipt, Connectivity, DinersInfo, JCBInfo, Key, KlarnaInfo, NyceInfo, PayAtTable, PayByBankPlaidInfo, Payment, PaymentMethod, PaymentMethodResponse, PaymentMethodSetupInfo, PayoutSettings, PulseInfo, Refunds, ReleaseUpdateDetails, ScheduleTerminalActionsRequestActionDetails, SplitConfigurationLogic, StarInfo, Store, TerminalAssignment, TerminalConnectivityCellular, TransactionDescriptionInfo, UninstallAndroidAppDetails, UpdateCompanyWebhookRequest, UpdateMerchantWebhookRequest, UpdateSplitConfigurationLogicRequest, and UpdateStoreRequest.
• New Models: Two new models, ForceRebootDetails and GivexInfo, have been added to the Management API.
• Enum Handling: Replaced InvalidArgumentException with error_log for invalid enum values to prevent exceptions from halting execution.
• Documentation Updates: Improved documentation for AdditionalSettings and AdditionalSettingsResponse to clarify the meaning of includeCaptureDelayHours.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a number of changes, including new models and properties, which appear to be auto-generated from an OpenAPI specification. While most changes are additive, there is a recurring critical issue across many files: the error handling for invalid enum values in setters has been changed from throwing an InvalidArgumentException to logging an error with error_log. This change means that the application will no longer fail fast when invalid data is used to construct model objects. Instead, it will silently log an error and continue execution with an object in an invalid state. This can lead to subtle bugs and makes debugging significantly harder. I have added comments on each occurrence of this pattern with a suggestion to revert to throwing an exception to ensure data integrity and robust error handling.

[gemini-code-assist]

Using error_log instead of throwing an exception for invalid enum values can lead to silent failures. The previous implementation with throw new \InvalidArgumentException was safer as it immediately stopped execution and notified the caller of the invalid data. With error_log, the invalid value is assigned to the property, and the program continues, potentially leading to unexpected behavior and making bugs harder to trace. It is highly recommended to revert to throwing an exception to enforce the model's contract and maintain data integrity.

            throw new \InvalidArgumentException(
                sprintf(
                    "processingType: unexpected enum value '%s' - Supported values are [%s]",
                    $processingType,
                    implode(', ', $allowedValues)
                )
            );

[gemini-code-assist]

Using error_log instead of throwing an exception for invalid enum values can lead to silent failures. The previous implementation with throw new \InvalidArgumentException was safer as it immediately stopped execution and notified the caller of the invalid data. With error_log, the invalid value is assigned to the property, and the program continues, potentially leading to unexpected behavior and making bugs harder to trace. It is highly recommended to revert to throwing an exception to enforce the model's contract and maintain data integrity.

            throw new \InvalidArgumentException(
                sprintf(
                    "pricePlan: unexpected enum value '%s' - Supported values are [%s]",
                    $pricePlan,
                    implode(', ', $allowedValues)
                )
            );

[gemini-code-assist]

Using error_log instead of throwing an exception for invalid enum values can lead to silent failures. The previous implementation with throw new \InvalidArgumentException was safer as it immediately stopped execution and notified the caller of the invalid data. With error_log, the invalid value is assigned to the property, and the program continues, potentially leading to unexpected behavior and making bugs harder to trace. It is highly recommended to revert to throwing an exception to enforce the model's contract and maintain data integrity.

            throw new \InvalidArgumentException(
                sprintf(
                    "serviceLevel: unexpected enum value '%s' - Supported values are [%s]",
                    $serviceLevel,
                    implode(', ', $allowedValues)
                )
            );

[gemini-code-assist]

Using error_log instead of throwing an exception for invalid enum values can lead to silent failures. The previous implementation with throw new \InvalidArgumentException was safer as it immediately stopped execution and notified the caller of the invalid data. With error_log, the invalid value is assigned to the property, and the program continues, potentially leading to unexpected behavior and making bugs harder to trace. It is highly recommended to revert to throwing an exception to enforce the model's contract and maintain data integrity.

            throw new \InvalidArgumentException(
                sprintf(
                    "status: unexpected enum value '%s' - Supported values are [%s]",
                    $status,
                    implode(', ', $allowedValues)
                )
            );

[gemini-code-assist]

Using error_log instead of throwing an exception for invalid enum values can lead to silent failures. The previous implementation with throw new \InvalidArgumentException was safer as it immediately stopped execution and notified the caller of the invalid data. With error_log, the invalid value is assigned to the property, and the program continues, potentially leading to unexpected behavior and making bugs harder to trace. It is highly recommended to revert to throwing an exception to enforce the model's contract and maintain data integrity.

            throw new \InvalidArgumentException(
                sprintf(
                    "simcardStatus: unexpected enum value '%s' - Supported values are [%s]",
                    $simcardStatus,
                    implode(', ', $allowedValues)
                )
            );

[gemini-code-assist]

Using error_log instead of throwing an exception for invalid enum values can lead to silent failures. The previous implementation with throw new \InvalidArgumentException was safer as it immediately stopped execution and notified the caller of the invalid data. With error_log, the invalid value is assigned to the property, and the program continues, potentially leading to unexpected behavior and making bugs harder to trace. It is highly recommended to revert to throwing an exception to enforce the model's contract and maintain data integrity.

            throw new \InvalidArgumentException(
                sprintf(
                    "communicationFormat: unexpected enum value '%s' - Supported values are [%s]",
                    $communicationFormat,
                    implode(', ', $allowedValues)
                )
            );

[gemini-code-assist]

Using error_log instead of throwing an exception for invalid enum values can lead to silent failures. The previous implementation with throw new \InvalidArgumentException was safer as it immediately stopped execution and notified the caller of the invalid data. With error_log, the invalid value is assigned to the property, and the program continues, potentially leading to unexpected behavior and making bugs harder to trace. It is highly recommended to revert to throwing an exception to enforce the model's contract and maintain data integrity.

            throw new \InvalidArgumentException(
                sprintf(
                    "acquiringFees: unexpected enum value '%s' - Supported values are [%s]",
                    $acquiringFees,
                    implode(', ', $allowedValues)
                )
            );

[gemini-code-assist]

Using error_log instead of throwing an exception for invalid enum values can lead to silent failures. The previous implementation with throw new \InvalidArgumentException was safer as it immediately stopped execution and notified the caller of the invalid data. With error_log, the invalid value is assigned to the property, and the program continues, potentially leading to unexpected behavior and making bugs harder to trace. It is highly recommended to revert to throwing an exception to enforce the model's contract and maintain data integrity.

            throw new \InvalidArgumentException(
                sprintf(
                    "status: unexpected enum value '%s' - Supported values are [%s]",
                    $status,
                    implode(', ', $allowedValues)
                )
            );

[gemini-code-assist]

Using error_log for invalid enum values can lead to silent failures. It is better to throw an InvalidArgumentException to immediately halt execution and alert the developer to the issue. With error_log, the invalid value is assigned to the property, and the program continues, potentially leading to unexpected behavior and making bugs harder to trace. It is highly recommended to throw an exception to enforce the model's contract and maintain data integrity.

            throw new \InvalidArgumentException(
                sprintf(
                    "pinSupport: unexpected enum value '%s' - Supported values are [%s]",
                    $pinSupport,
                    implode(', ', $allowedValues)
                )
            );

[gemini-code-assist]

Using error_log instead of throwing an exception for invalid enum values can lead to silent failures. The previous implementation with throw new \InvalidArgumentException was safer as it immediately stopped execution and notified the caller of the invalid data. With error_log, the invalid value is assigned to the property, and the program continues, potentially leading to unexpected behavior and making bugs harder to trace. It is highly recommended to revert to throwing an exception to enforce the model's contract and maintain data integrity.

            throw new \InvalidArgumentException(
                sprintf(
                    "communicationFormat: unexpected enum value '%s' - Supported values are [%s]",
                    $communicationFormat,
                    implode(', ', $allowedValues)
                )
            );

[sonarqubecloud]

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
77.4% Duplication on New Code

See analysis details on SonarQube Cloud