[balanceplatform] Code generation: update services and models#865
[balanceplatform] Code generation: update services and models#865
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the latest updates from the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces several new models and enums related to Strong Customer Authentication (SCA) device management and balance webhook settings. New SCA-related models include ApproveAssociationRequest, ApproveAssociationResponse, Association, AssociationListing, BeginScaDeviceRegistrationRequest, BeginScaDeviceRegistrationResponse, RemoveAssociationRequest, ScaDevice, ScaEntity, SubmitScaAssociationRequest, and SubmitScaAssociationResponse, along with enums AssociationStatus, ScaDeviceType, and ScaEntityType. For balance webhooks, new models BalanceWebhookSetting, BalanceWebhookSettingAllOf, BalanceWebhookSettingInfo, BalanceWebhookSettingInfoUpdate, Condition, Target, TargetUpdate, WebhookSetting, WebhookSettings, and SettingType were added. Existing models received updates: Amount.php had minor Javadoc improvements for currency and value parameters. BulkAddress.php gained new optional fields line1, line2, line3, and name. The Card.php model's number field was made optional (nullable) and its validation adjusted. CardConfiguration.php saw Javadoc clarifications for several fields like activation, cardImageId, carrier, carrierImageId, configurationProfileId, currency, envelope, insert, logoImageId, pinMailer, and shipmentMethod. DeviceInfo.php was simplified by removing several properties (cardCaptureTechnology, deviceName, imei, isoDeviceType, msisdn, osVersion, paymentTypes, serialNumber, storageTechnology) and updating Javadoc for formFactor and osName. HKLocalAccountIdentification.php updated the accountNumber parameter description to allow a 17-digit number. CreateSweepConfigurationV2.php, SweepConfigurationV2.php, and UpdateSweepConfigurationV2.php added a new SCHEME_ADVICE reason. TransactionRule.php and TransactionRuleInfo.php updated the outcomeType Javadoc to include enforceSCA and clarify scoreBased restrictions. Finally, VerificationError.php and VerificationErrorRecursive.php added a dataReview type to their respective type enums. The review comment specifically noted the change in Card.php where the setNumber() parameter type was updated to string|null, making the number field nullable.
| /** | ||
| * Sets number | ||
| * | ||
| * @param string $number The primary account number (PAN) of the card. > The PAN is masked by default and returned only for single-use virtual cards. | ||
| * @param string|null $number The primary account number (PAN) of the card. > The PAN is masked by default and returned only for single-use virtual cards. | ||
| * | ||
| * @return self | ||
| */ |
There was a problem hiding this comment.
The parameter type for setNumber() has been updated to string|null, reflecting that the number field can now be null. This change should be confirmed against the API's expected behavior for setting this value.
* @param string|null $number The primary account number (PAN) of the card. > The PAN is masked by default and returned only for single-use virtual cards.
*
* @return self
*/4ea6d8c to
b633d38
Compare
3553be0 to
af645ff
Compare
af645ff to
af23616
Compare
|



This PR contains the automated changes for the
balanceplatformservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.Balance Platform
name,line1,line2,line3inBulkAddressnumberinCardphoneinDeviceInfodataReviewinVerificationErrorandVerificationErrorRecursiveSeveral attributes (
cardCaptureTechnology,deviceName,imei,isoDeviceType,msisdn,osVersion,paymentTypes,serialNumber,storageTechnology) have been removedDeviceInfo: this is NOT considered a breaking change since those attributes were never included in the API responseNote
In
SweepConfigurationV2,CreateSweepConfigurationV2andUpdateSweepConfigurationV2several enum values have been deleted (REASON_APPROVAL_EXPIRED,REASON_DECLINED, etc..), however those values were never delivered or used.