Skip to content

[balanceplatform] Code generation: update services and models#865

Merged
gcatanese merged 2 commits intomainfrom
sdk-automation/balanceplatform
Jan 27, 2026
Merged

[balanceplatform] Code generation: update services and models#865
gcatanese merged 2 commits intomainfrom
sdk-automation/balanceplatform

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

@AdyenAutomationBot AdyenAutomationBot commented Jan 13, 2026

This PR contains the automated changes for the balanceplatform service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

Balance Platform

  • Add attributes name, line1, line2, line3 in BulkAddress
  • Make optional attribute number in Card
  • Add attribute phone in DeviceInfo
  • Add enum value dataReview in VerificationError and VerificationErrorRecursive

⚠️ Removing of unused attributes
Several attributes (cardCaptureTechnology, deviceName, imei, isoDeviceType, msisdn, osVersion, paymentTypes, serialNumber, storageTechnology) have been removed DeviceInfo: this is NOT considered a breaking change since those attributes were never included in the API response

Note

In SweepConfigurationV2, CreateSweepConfigurationV2 and UpdateSweepConfigurationV2 several enum values have been deleted (REASON_APPROVAL_EXPIRED, REASON_DECLINED, etc..), however those values were never delivered or used.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners January 13, 2026 14:59
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the latest updates from the adyen-openapi specification into the balanceplatform service. The primary focus is on expanding the API's capabilities for managing Strong Customer Authentication (SCA) devices and associations, as well as introducing new features for configuring balance-related webhooks. These changes ensure the service remains aligned with the most recent API definitions, providing enhanced security and notification options.

Highlights

  • New SCA Device Management APIs: Introduced new services and models for Strong Customer Authentication (SCA) device management, including functionality to begin and finish device registration, approve associations, list associations, and remove associations.
  • New Balance Webhook Settings: Added new models for configuring balance webhook settings, allowing for more granular control over when notifications are triggered based on balance conditions.
  • Model Enhancements and Clarifications: Updated several existing models across the Balance Platform API, including Amount, BulkAddress, Card, CardConfiguration, DeviceInfo, HKLocalAccountIdentification, SweepConfigurationV2, TransactionRule, and TransferRoute to refine property descriptions, adjust data types, and add new fields for improved clarity and functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new models and enums related to Strong Customer Authentication (SCA) device management and balance webhook settings. New SCA-related models include ApproveAssociationRequest, ApproveAssociationResponse, Association, AssociationListing, BeginScaDeviceRegistrationRequest, BeginScaDeviceRegistrationResponse, RemoveAssociationRequest, ScaDevice, ScaEntity, SubmitScaAssociationRequest, and SubmitScaAssociationResponse, along with enums AssociationStatus, ScaDeviceType, and ScaEntityType. For balance webhooks, new models BalanceWebhookSetting, BalanceWebhookSettingAllOf, BalanceWebhookSettingInfo, BalanceWebhookSettingInfoUpdate, Condition, Target, TargetUpdate, WebhookSetting, WebhookSettings, and SettingType were added. Existing models received updates: Amount.php had minor Javadoc improvements for currency and value parameters. BulkAddress.php gained new optional fields line1, line2, line3, and name. The Card.php model's number field was made optional (nullable) and its validation adjusted. CardConfiguration.php saw Javadoc clarifications for several fields like activation, cardImageId, carrier, carrierImageId, configurationProfileId, currency, envelope, insert, logoImageId, pinMailer, and shipmentMethod. DeviceInfo.php was simplified by removing several properties (cardCaptureTechnology, deviceName, imei, isoDeviceType, msisdn, osVersion, paymentTypes, serialNumber, storageTechnology) and updating Javadoc for formFactor and osName. HKLocalAccountIdentification.php updated the accountNumber parameter description to allow a 17-digit number. CreateSweepConfigurationV2.php, SweepConfigurationV2.php, and UpdateSweepConfigurationV2.php added a new SCHEME_ADVICE reason. TransactionRule.php and TransactionRuleInfo.php updated the outcomeType Javadoc to include enforceSCA and clarify scoreBased restrictions. Finally, VerificationError.php and VerificationErrorRecursive.php added a dataReview type to their respective type enums. The review comment specifically noted the change in Card.php where the setNumber() parameter type was updated to string|null, making the number field nullable.

Comment on lines 688 to 694
/**
* Sets number
*
* @param string $number The primary account number (PAN) of the card. > The PAN is masked by default and returned only for single-use virtual cards.
* @param string|null $number The primary account number (PAN) of the card. > The PAN is masked by default and returned only for single-use virtual cards.
*
* @return self
*/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The parameter type for setNumber() has been updated to string|null, reflecting that the number field can now be null. This change should be confirmed against the API's expected behavior for setting this value.

     * @param string|null $number The primary account number (PAN) of the card. > The PAN is masked by default and returned only for single-use virtual cards.
     *
     * @return self
     */

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch 4 times, most recently from 4ea6d8c to b633d38 Compare January 16, 2026 12:55
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch 3 times, most recently from 3553be0 to af645ff Compare January 26, 2026 09:45
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from af645ff to af23616 Compare January 26, 2026 16:55
@sonarqubecloud
Copy link
Copy Markdown

@gcatanese gcatanese added this pull request to the merge queue Jan 27, 2026
Merged via the queue into main with commit 2a24206 Jan 27, 2026
9 checks passed
@gcatanese gcatanese deleted the sdk-automation/balanceplatform branch January 27, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants