Skip to content

[balanceplatform] Code generation: update services and models#877

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/balanceplatform
Open

[balanceplatform] Code generation: update services and models#877
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/balanceplatform

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the balanceplatform service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners January 27, 2026 14:38
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces significant updates to the Balance Platform API, focusing on enhancing security through SCA device management and improving notification capabilities with balance webhook settings. These changes provide developers with more fine-grained control and improved integration options for managing balances and security within the Adyen platform.

Highlights

  • New Models: Introduces several new data models for the Balance Platform API, enhancing the structure and clarity of requests and responses related to SCA (Strong Customer Authentication) device management and webhook settings.
  • SCA Device Management: Adds functionality for managing SCA devices, including device registration, association, and approval processes, improving security and compliance.
  • Webhook Settings: Implements webhook settings for balance updates, allowing for more granular control over notifications based on defined conditions.
  • API Endpoints: Defines new API endpoints for managing SCA associations and balance webhook settings, providing developers with more control over these features.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces several new models and API services for the balanceplatform service. The changes appear to be auto-generated, which is generally good for consistency. However, there are some inconsistencies in nullability declarations and validation logic across several model classes, as well as hardcoded base URLs in the API service classes. Addressing these will improve the robustness and maintainability of the generated code.

'entityId' => false,
'entityType' => false,
'scaDeviceId' => false,
'scaDeviceName' => false,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The scaDeviceName property is marked as non-nullable (false) in openAPINullables, but its getter/setter docblocks (lines 435, 449) indicate it can be string|null. This creates an inconsistency in how the property's nullability is communicated and handled. Please ensure openAPINullables accurately reflects the intended nullability, and if it can be null, update the listInvalidProperties method accordingly.

$invalidProperties[] = "'entityType' can't be null";
}
if ($this->container['scaDeviceId'] === null) {
$invalidProperties[] = "'scaDeviceId' can't be null";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The scaDeviceName property is marked as non-nullable in openAPINullables (line 80), but it is not explicitly checked for null in listInvalidProperties(). If it's truly non-nullable, it should be validated here.

        if ($this->container['scaDeviceId'] === null) {
            $invalidProperties[] = "'scaDeviceId' can't be null";
        }
        if ($this->container['scaDeviceName'] === null) {
            $invalidProperties[] = "'scaDeviceName' can't be null";
        }

{
$invalidProperties = [];

return $invalidProperties;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The conditions property is marked as non-nullable (false) in openAPINullables (line 65), but it is not explicitly checked for null in listInvalidProperties(). If it's truly non-nullable, it should be validated here.

        $invalidProperties = [];

        if ($this->container['conditions'] === null) {
            $invalidProperties[] = "'conditions' can't be null";
        }
        return $invalidProperties;

* @var boolean[]
*/
protected static $openAPINullables = [
'conditions' => false,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The conditions property is marked as non-nullable (false) in openAPINullables, but its getter/setter docblocks (lines 361, 374) indicate it can be Condition[]|null. This creates an inconsistency in how the property's nullability is communicated and handled. Please ensure openAPINullables accurately reflects the intended nullability, and if it can be null, update the listInvalidProperties method accordingly.

{
$invalidProperties = [];

if ($this->container['currency'] === null) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The conditions property is marked as non-nullable in openAPINullables (line 72), but it is not explicitly checked for null in listInvalidProperties(). If it's truly non-nullable, it should be validated here.

        if ($this->container['conditions'] === null) {
            $invalidProperties[] = "'conditions' can't be null";
        }
        if ($this->container['currency'] === null) {

*/
protected static $openAPINullables = [
'webhookSettings' => false
];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The webhookSettings property is marked as non-nullable (false) in openAPINullables, but its getter/setter docblocks (lines 279, 292) indicate it can be WebhookSetting[]|null. This creates an inconsistency in how the property's nullability is communicated and handled. Please ensure openAPINullables accurately reflects the intended nullability, and if it can be null, update the listInvalidProperties method accordingly.

{
$invalidProperties = [];

return $invalidProperties;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The webhookSettings property is marked as non-nullable in openAPINullables (line 65), but it is not explicitly checked for null in listInvalidProperties(). If it's truly non-nullable, it should be validated here.

        $invalidProperties = [];

        if ($this->container['webhookSettings'] === null) {
            $invalidProperties[] = "'webhookSettings' can't be null";
        }
        return $invalidProperties;

Comment on lines +39 to +40
$this->baseURL = $this->createBaseUrl("https://balanceplatform-api-test.adyen.com/bcl/v2");
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The baseURL is hardcoded to a test environment URL. It should dynamically construct the base URL using createBaseUrl with a base path (e.g., "/bcl/v2") to correctly handle both test and live environments based on the client configuration.

        $this->baseURL = $this->createBaseUrl("balanceplatform-api", "/bcl/v2");

Comment on lines +39 to +40
$this->baseURL = $this->createBaseUrl("https://balanceplatform-api-test.adyen.com/bcl/v2");
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The baseURL is hardcoded to a test environment URL. It should dynamically construct the base URL using createBaseUrl with a base path (e.g., "/bcl/v2") to correctly handle both test and live environments based on the client configuration.

        $this->baseURL = $this->createBaseUrl("balanceplatform-api", "/bcl/v2");

Comment on lines +39 to +40
$this->baseURL = $this->createBaseUrl("https://balanceplatform-api-test.adyen.com/bcl/v2");
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The baseURL is hardcoded to a test environment URL. It should dynamically construct the base URL using createBaseUrl with a base path (e.g., "/bcl/v2") to correctly handle both test and live environments based on the client configuration.

        $this->baseURL = $this->createBaseUrl("balanceplatform-api", "/bcl/v2");

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from 6b4e412 to b40ce01 Compare February 2, 2026 09:16
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from b40ce01 to a320e42 Compare February 9, 2026 12:33
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from a320e42 to c60a813 Compare February 17, 2026 21:49
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from c60a813 to bb799cd Compare March 5, 2026 17:37
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from bb799cd to 343949b Compare March 18, 2026 16:03
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch 5 times, most recently from ccb7a14 to bbf54df Compare April 14, 2026 14:43
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from bbf54df to 25b7594 Compare April 15, 2026 07:59
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant