Extract shared/hooks-preact#1106
Open
german664 wants to merge 1 commit intogroup/nx-migration-phase-1from
Open
Extract shared/hooks-preact#1106german664 wants to merge 1 commit intogroup/nx-migration-phase-1from
german664 wants to merge 1 commit intogroup/nx-migration-phase-1from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request extracts Preact-specific hooks into a new shared package, @integration-components/hooks-preact, and refactors existing hooks to re-export from this package. Feedback identifies a typo in an ARIA attribute and suggests performance optimizations by replacing object spreading in loops and reducers with direct mutation. Additionally, it is recommended to use style.setProperty instead of setAttribute for more efficient and non-destructive style updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract reusable Preact hooks into
packages/shared/hooks-preact.Fixed issue: IEX-2470