Merged
Conversation
Merge develop in group/transactions
Transactions overview context and shell component
german664
previously approved these changes
Apr 17, 2026
Contributor
|
Size Change: +1.15 kB (+0.25%) Total Size: 464 kB 📦 View Changed
ℹ️ View Unchanged
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Transactions Overview feature by introducing a TransactionsOverviewContext to centralize state management and eliminate prop drilling across its sub-components. Key changes include the creation of a TransactionsOverviewProvider, the introduction of a TransactionsOverviewShell for layout, and the renaming of several interfaces for consistency. Feedback was provided regarding the use of Record<never, never> in component props and the potential ineffectiveness of useMemo for the context value due to unstable hook dependencies.
glad-adyen
force-pushed
the
group/transactions-insights
branch
from
2d4613d to
36e38e9
Compare
glad-adyen
force-pushed
the
group/transactions-insights
branch
from
36e38e9 to
91f083d
Compare
german664
approved these changes
Apr 17, 2026
isuert
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces changes needed as pre-work for
TransactionsInsightscomponent.