Skip to content

Don't use "CRITICAL" stream for standard logging#219

Draft
jamiecook wants to merge 1 commit into
developfrom
jamiecook-patch-1
Draft

Don't use "CRITICAL" stream for standard logging#219
jamiecook wants to merge 1 commit into
developfrom
jamiecook-patch-1

Conversation

@jamiecook

@jamiecook jamiecook commented May 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This should help to address confusion like #214
We could also do something like

level = Info
if "WARNING" in line:
    level = Warning
if "ERROR" in line:
    level = Critical
log(line, level)

NOTE: Code is currently untested.

@jamiecook jamiecook changed the title Not critical Don't use "CRITICAL" stream for standard logging May 18, 2023
@jamiecook jamiecook requested a review from pedrocamargo May 18, 2023 19:37
@jamiecook jamiecook marked this pull request as draft May 18, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrocamargo pedrocamargo pedrocamargo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamiecook @pedrocamargo