Skip to content

[WIP] matrix calculator, matrix import/updt, faster project creation#354

Open
Art-Ev wants to merge 16 commits into
AequilibraE:developfrom
Art-Ev:develop
Open

[WIP] matrix calculator, matrix import/updt, faster project creation#354
Art-Ev wants to merge 16 commits into
AequilibraE:developfrom
Art-Ev:develop

Conversation

@Art-Ev

@Art-Ev Art-Ev commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

Renaming processings to handle menus order & add datetime to assignment result name for easier re-running without editing yaml config file

Art-Ev added 3 commits May 23, 2024 17:53
@Art-Ev
Revision of AequilibraE#250 (Adding QGIS processing provider)
59583a3 
Should be ready for merge, full revision of "old" PR AequilibraE#250 :
* Adding processing provider (translatable)
* Include traffic assignment from yaml
@Art-Ev
Renaming processings to handle menus order & add datetime to assignme…
bc718fa 
…nt result for easier re-running
@Art-Ev
Differentiation between creating a new aem file and adding a matrix t…
3be45ba 
…o an existing file

Preparing a new future QGIS provider : "matrix calculator"
@Art-Ev Art-Ev changed the title Renaming processings & running datetime to assignments results Renaming processings, easier re-running of assignment & proccessings to manage addition/update of matrix to an existing aem file Jun 17, 2024
@Art-Ev Art-Ev changed the title Renaming processings, easier re-running of assignment & proccessings to manage addition/update of matrix to an existing aem file [WIP] Renaming processings, easier re-running of assignment & proccessings to manage addition/update of matrix to an existing aem file Jun 18, 2024
@pedrocamargo pedrocamargo requested a review from r-akemii June 18, 2024 09:10
r-akemii
r-akemii reviewed Jun 18, 2024
View reviewed changes
Comment thread qaequilibrae/modules/processing_provider/Add_connectors.py
r-akemii
r-akemii reviewed Jun 18, 2024
View reviewed changes
Comment thread qaequilibrae/modules/processing_provider/add_matrix_from_layer.py
r-akemii
r-akemii reviewed Jun 18, 2024
View reviewed changes
Comment thread qaequilibrae/modules/processing_provider/add_matrix_from_layer.py Outdated
r-akemii
r-akemii reviewed Jun 18, 2024
View reviewed changes
Comment thread qaequilibrae/modules/processing_provider/add_matrix_from_layer.py Outdated
r-akemii
r-akemii reviewed Jun 18, 2024
View reviewed changes
Comment thread qaequilibrae/modules/processing_provider/add_matrix_from_layer.py Outdated
r-akemii
r-akemii reviewed Jun 18, 2024
View reviewed changes
Comment thread qaequilibrae/modules/processing_provider/create_matrix_from_layer.py Outdated
r-akemii
r-akemii reviewed Jun 18, 2024
View reviewed changes
Comment thread qaequilibrae/modules/processing_provider/assign_from_yaml.py Outdated
r-akemii
r-akemii reviewed Jun 18, 2024
View reviewed changes
Comment thread qaequilibrae/modules/processing_provider/add_matrix_from_layer.py Outdated
@r-akemii

r-akemii commented Jun 19, 2024

Copy link
Copy Markdown
Collaborator

@Art-Ev by the way, do you have any sample files you're using to test the provider to send me?

@Art-Ev

Art-Ev commented Jun 19, 2024

Copy link
Copy Markdown
Contributor Author

@Art-Ev by the way, do you have any sample files you're using to test the provider to send me?

Not yet, it's one shots every time... But we have somebody with whom we'll be working on this over the summer: a full model creation and running using only qgis processes from the provider with precalculated results to validate future updates and future new functions. Goal is to have one QGIS modeler that we can juste run with one button and check that most functions work as expected.

@r-akemii

r-akemii commented Jul 4, 2024

Copy link
Copy Markdown
Collaborator

@Art-Ev I did a super mess in your branch / commit :( Je suis vraiment désolée de vous dérranger

@Art-Ev

Art-Ev commented Jul 4, 2024

Copy link
Copy Markdown
Contributor Author

@Art-Ev I did a super mess in your branch / commit :( Je suis vraiment désolée de vous dérranger

Seen that trying to push last commit 😋 I think it's good now (had lot of errors before but final files in "files changes" tab seem to be correct at the end)

@Art-Ev Art-Ev changed the title [WIP] Renaming processings, easier re-running of assignment & proccessings to manage addition/update of matrix to an existing aem file [WIP] matrix calculator, matrix import/updt, faster project creation Jul 4, 2024
r-akemii
r-akemii reviewed Aug 15, 2024
View reviewed changes
Comment thread qaequilibrae/modules/processing_provider/Add_connectors.py
from qgis.core import QgsProcessingParameterFile, QgsProcessingParameterNumber, QgsProcessingParameterString
from qgis.core import QgsFeature, QgsVectorLayer, QgsDataSourceUri

import processing

@r-akemii r-akemii Aug 15, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Art-Ev I want to check with you about this import because the test I wrote is failing with these changes. I tried to import this module but I received an error. Would you mind checking this for me, please?

@Art-Ev Art-Ev Aug 19, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, will check that, which version of QGIS are you using ? (no error on 2 different versions on my computer nor on another person's...)

@r-akemii r-akemii Dec 4, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Art-Ev I'm updating the tests based on the changes in your branch and I still have problems importing processing. My container is using QGIS LTR (3.34.13 IMO) . Can you please check this import for me?

Art-Ev added 3 commits August 27, 2024 18:38
@Art-Ev
debugging qgis file filter and co
abd64d3
@Art-Ev
Numerous bug corrections
0ed6a4e
@Art-Ev
Bug correction
1121b6e 
New problems with PT assignment/graph creation but working ont it...
@Art-Ev

Art-Ev commented Oct 8, 2024

Copy link
Copy Markdown
Contributor Author

@r-akemii, we've made some tests and only have a last problem : PT assign and map matching are buggy on our side. (errors during graph creation). Can you check that ? If you see no problem on your side we'll organize a call to send you our test files.

@r-akemii

r-akemii commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

@Art-Ev I can definitely investigate the bug! Would you mind describing it and sending me the GTFS files you were using?

I have a hunch that it can be related to a bug Pedro fixed in AequilibraE in release 1.1.0.

@Art-Ev

Art-Ev commented Oct 8, 2024

Copy link
Copy Markdown
Contributor Author

@Art-Ev I can definitely investigate the bug! Would you mind describing it and sending me the GTFS files you were using?

I have a hunch that it can be related to a bug Pedro fixed in AequilibraE in release 1.1.0.

Will make that tomorrow ;)

@r-akemii

r-akemii commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

@Art-Ev I'm not sure if I can reach you on Teams, but I'll contact you tomorrow during your working hours!

@r-akemii r-akemii mentioned this pull request Dec 10, 2024
Merged
@Art-Ev Art-Ev mentioned this pull request Apr 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r-akemii r-akemii r-akemii left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Art-Ev @r-akemii