PR 144: [BUG]: Fix bHidden updates and general context, allow some interaction with notification and force one app-instance#144
Open
n3m3s7s wants to merge 1 commit intoAetherinox:mainfrom
Open
Conversation
…notification and force one app-instance
Collaborator
Automatic Self-Check - #144The details of our automated scan for your pull request are listed below. If our scan detected errors, they must be corrected before this pull request will be advanced to the review stage: AboutThis pull request includes the following information:
❌ Skipped FilesTip The following file(s) have been skipped:
This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bHidden updates and general context
sometimes the "bHidden" variable - which is a global variable tracking the main window visibility status - is not correctly updated, especially when reacting on some events such as "minimize window", "minimize to tray" and/or when changing the visibility on user interacton from different locations;
now the variable should be properly updated and reactive, and the Windows visibility should change instantly;
Allow some interaction with notification
Now when a notification is showed after a successfull polling request, that notification has been modified to be able to:
since a NTFY message can have a "click" attribute (which should be an absolute URL), clicking on the notification will open the default browser (and not in electron); this only when the "click" variable exist in the payload and is not null or an empty string;
clicking on the notification will try to show (or wake up) the main window (as expected);
Force only one app instance at any time
Since most users are not tech-guys they usually open the application several times, and this causes a lot of issues;
Yes, this could be mitigate with the option "Always quit app" but is not very convenient, especially if You want every user to receive notifications even when they are not using the PC;
so basically now - since is possibile via Electron - the workflow will take care to allow only one instance of Ntfy-Desktop;