Skip to content

PR 144: [BUG]: Fix bHidden updates and general context, allow some interaction with notification and force one app-instance#144

Open
n3m3s7s wants to merge 1 commit intoAetherinox:mainfrom
n3m3s7s:main
Open

PR 144: [BUG]: Fix bHidden updates and general context, allow some interaction with notification and force one app-instance#144
n3m3s7s wants to merge 1 commit intoAetherinox:mainfrom
n3m3s7s:main

Conversation

@n3m3s7s
Copy link
Copy Markdown

@n3m3s7s n3m3s7s commented Dec 3, 2025

Fix bHidden updates and general context

  • Bug

sometimes the "bHidden" variable - which is a global variable tracking the main window visibility status - is not correctly updated, especially when reacting on some events such as "minimize window", "minimize to tray" and/or when changing the visibility on user interacton from different locations;

now the variable should be properly updated and reactive, and the Windows visibility should change instantly;


Allow some interaction with notification

  • Feature

Now when a notification is showed after a successfull polling request, that notification has been modified to be able to:

  • since a NTFY message can have a "click" attribute (which should be an absolute URL), clicking on the notification will open the default browser (and not in electron); this only when the "click" variable exist in the payload and is not null or an empty string;

  • clicking on the notification will try to show (or wake up) the main window (as expected);


Force only one app instance at any time

  • Feature

Since most users are not tech-guys they usually open the application several times, and this causes a lot of issues;
Yes, this could be mitigate with the option "Always quit app" but is not very convenient, especially if You want every user to receive notifications even when they are not using the PC;

so basically now - since is possibile via Electron - the workflow will take care to allow only one instance of Ntfy-Desktop;

@BinaryServ BinaryServ changed the title [BUG]: Fix bHidden updates and general context, allow some interaction with notification and force one app-instance PR 144: [BUG]: Fix bHidden updates and general context, allow some interaction with notification and force one app-instance Dec 3, 2025
@BinaryServ BinaryServ added AC › Passed Ready to be reviewed Type › Pull Request Normal pull request labels Dec 3, 2025
@BinaryServ
Copy link
Copy Markdown
Collaborator


Automatic Self-Check - #144

The details of our automated scan for your pull request are listed below. If our scan detected errors, they must be corrected before this pull request will be advanced to the review stage:




About

This pull request includes the following information:

Category Value
Title [BUG]: Fix bHidden updates and general context, allow some interaction with notification and force one app-instance
Created 12.03.2025 11:32 AM UTC
ID #144
Author n3m3s7s
Repo ntfy-desktop
Branch main main
Added Files 0
Modified Files 2
Renamed Files 0
Copied Files 0
Deleted Files 0



❌ Skipped Files

Tip

The following file(s) have been skipped:


  • src/index.js
  • src/package.json



This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AC › Passed Ready to be reviewed Type › Pull Request Normal pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants