Express Checkout PR 4: Order Confirmation & Placement#95
Open
daniellzl wants to merge 8 commits intodl260302/express-checkout-pr3-shipping-totalsfrom
Open
Express Checkout PR 4: Order Confirmation & Placement#95daniellzl wants to merge 8 commits intodl260302/express-checkout-pr3-shipping-totalsfrom
daniellzl wants to merge 8 commits intodl260302/express-checkout-pr3-shipping-totalsfrom
Conversation
Implements Step 4 of the Affirm Express Checkout Integration Guide: - readCheckout API (affirmAPI.js): reads checkout details from Affirm - ExpressConfirmation controller route: applies shipping/billing from Affirm checkout data, authorizes, creates order, places order, sends confirmation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Separate service entry for the v2 checkout read endpoint, distinct from the v1 transaction read service. Provides independent monitoring and configuration in Business Manager. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
virginiac32
reviewed
Mar 19, 2026
virginiac32
left a comment
virginiac32
left a comment
There was a problem hiding this comment.
Could you add tests for the changes made in the 4 PRs?
| }; | ||
| } | ||
| }; | ||
| /** |
There was a problem hiding this comment.
Unrelated to this change, but the auth() function should take a new orderId field so that the order id can be updated during auth call
This was referenced Mar 20, 2026
…60302/express-checkout-pr4-confirmation
…60302/express-checkout-pr4-confirmation
…60302/express-checkout-pr4-confirmation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tech Spec
Summary
PR Stack (4 of 4)
Implements Step 4 of the Affirm Express Checkout Integration Guide.
Test plan