Fixes AgShare cloud load and real-time log viewer#1189
Merged
richardklasens merged 12 commits intohotpatch/6.8.2from Apr 15, 2026
Merged
Fixes AgShare cloud load and real-time log viewer#1189richardklasens merged 12 commits intohotpatch/6.8.2from
richardklasens merged 12 commits intohotpatch/6.8.2from
Conversation
- Auto-download latest field from cloud on open when AgShareAutoLoad is enabled - FileOpenField made async; TryLoadFromAgShareAsync inserted centrally - AgShareAutoLoad toggle button added to FormAgShareSettings - FormAgShareSettings redesigned with clean 3-zone layout - All AgShare UI strings moved to gStr translations (22 new keys) - Cloud load status label added to FormJob (visible when auto-load active) - Success/failure messages for cloud field load use translation keys Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
24 new gsAgShare* strings translated for all five languages. Czech (CS) was missing gsAgShareDownloader too, added as well. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Nudge step size is tool-specific, not global. Moved from Environment (Settings.cs) to Tool profile (ToolSettings.cs). All read/write references updated to ToolSettings.Default. FormAllSettings rows moved from PopulateEnvironment to PopulateTool. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Prevents unsaved in-memory changes from being lost when the user switches to a different profile in FormLoadVehicleTool. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace line-by-line AppendText loop with File.ReadAllText + single Text assignment, avoiding thousands of RichTextBox redraws. Extracted shared logic into LoadLog() used by both Load and Refresh. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Auto-scrolls to bottom on open and after new content arrives - Timer (1s) appends only new file/session content without full reload - Scroll position is preserved between ticks; no flicker Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace byte-based size trimming with line-count trimming. CheckLogSize now keeps the last 100 lines (configurable via parameter). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Auto-Upload and Cloud Load buttons now enable Save when toggled - Both buttons are disabled when AgShare is not activated - Removed redundant buttonSave.Enabled from UpdateAgShareUploadButton Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fixes MSB3270 architecture mismatch warning. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97b8954072
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!Guid.TryParse(idText, out Guid fieldId)) return; | ||
|
|
||
| var downloader = new AgShareDownloader(agShareClient); | ||
| bool success = await downloader.DownloadAndSaveAsync(fieldId); |
There was a problem hiding this comment.
TryLoadFromAgShareAsync downloads by field ID and then continues opening the originally selected fileAndDirectory, but the downloader writes files under Path.Combine(fieldsDirectory, model.Name) (cloud field name). When the local folder name differs from the cloud name (for example after a rename), the download succeeds but the app still opens stale local files from the old directory. This makes the new cloud-load behavior silently incorrect for renamed/mismatched fields.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances AgShare functionality with automatic cloud field loading, improves the event logging system for real-time monitoring, and refactors guidance settings for better tool profile management.
AgShare
Logging
Settings & Profiles
Other Improvements
Checklist