AgShare cloud load, settings improvements and bug fixes (6.8.3)#1190
Merged
richardklasens merged 28 commits intomasterfrom Apr 15, 2026
Merged
AgShare cloud load, settings improvements and bug fixes (6.8.3)#1190richardklasens merged 28 commits intomasterfrom
richardklasens merged 28 commits intomasterfrom
Conversation
Master sync
Ensure guidance patterns are correctly registered in the IdTable and assigned unique IDs instead of manually inheriting the guidance group ID.
Manually assign the guidance pattern ID by replacing the "GGP" prefix from the parent guidance group with "GPN", ensuring a consistent relationship instead of relying on generic ID assignment from the IdTable.
Ensure the steering angle direction is correctly interpreted in CSmartWAS by flipping the sample sign when the wheel angle sensor inversion setting is active.
…keeping the token up to date as well, it appears to have expired already resulting in 401 errors), so removing that dependency
…a merge somehow. Anyway...!
… throw an exception
fix for github rate limiting issue with api token
- Auto-download latest field from cloud on open when AgShareAutoLoad is enabled - FileOpenField made async; TryLoadFromAgShareAsync inserted centrally - AgShareAutoLoad toggle button added to FormAgShareSettings - FormAgShareSettings redesigned with clean 3-zone layout - All AgShare UI strings moved to gStr translations (22 new keys) - Cloud load status label added to FormJob (visible when auto-load active) - Success/failure messages for cloud field load use translation keys Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
24 new gsAgShare* strings translated for all five languages. Czech (CS) was missing gsAgShareDownloader too, added as well. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Nudge step size is tool-specific, not global. Moved from Environment (Settings.cs) to Tool profile (ToolSettings.cs). All read/write references updated to ToolSettings.Default. FormAllSettings rows moved from PopulateEnvironment to PopulateTool. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Prevents unsaved in-memory changes from being lost when the user switches to a different profile in FormLoadVehicleTool. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace line-by-line AppendText loop with File.ReadAllText + single Text assignment, avoiding thousands of RichTextBox redraws. Extracted shared logic into LoadLog() used by both Load and Refresh. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Auto-scrolls to bottom on open and after new content arrives - Timer (1s) appends only new file/session content without full reload - Scroll position is preserved between ticks; no flicker Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace byte-based size trimming with line-count trimming. CheckLogSize now keeps the last 100 lines (configurable via parameter). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Auto-Upload and Cloud Load buttons now enable Save when toggled - Both buttons are disabled when AgShare is not activated - Removed redundant buttonSave.Enabled from UpdateAgShareUploadButton Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fixes MSB3270 architecture mismatch warning. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fixes AgShare cloud load and real-time log viewer moves Snapdistance setting to ToolSettings
…keeping the token up to date as well, it appears to have expired already resulting in 401 errors), so removing that dependency
…a merge somehow. Anyway...!
… throw an exception
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 941eeeff78
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+18
to
+20
| if (!System.Diagnostics.Debugger.IsAttached) | ||
| { | ||
| System.Diagnostics.Debugger.Launch(); |
There was a problem hiding this comment.
Calling Debugger.Launch() whenever no debugger is attached means every normal updater start will trigger a JIT-debugger prompt (or fail on systems without a debugger configured), which breaks unattended/silent update flows and can block end users from updating; this should not run in production startup code.
Useful? React with 👍 / 👎.
Comment on lines
+89
to
+90
| public double setAS_snapDistance = 20.0; | ||
| public double setAS_snapDistanceRef = 5.0; |
There was a problem hiding this comment.
These new fields default to 20.0/5.0, but this change also removes snap-distance reads from environment settings and switches nudge behavior to ToolSettings without copying existing persisted values, so upgrades with customized snap distances silently reset to defaults per tool profile and alter guidance behavior until users reconfigure manually.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotpatch with AgShare improvements, small settings fixes and maintenance.
AgShare
the latest version is automatically downloaded before the field is opened
(Open, Resume, Drive In). Controlled by a new per-user toggle in the
AgShare settings form.
strings moved to the translations resource.
AgShare is not activated.
Settings
setAS_snapDistanceandsetAS_snapDistanceRef(nudge step size) movedfrom Environment to Tool profile — makes more sense as a per-tool value.
different profile in FormLoadVehicleTool, preventing loss of unsaved changes.
Log Viewer
AppendTextredraws — now loadsin one shot.
lines, no flicker).
growing indefinitely.
Updater
was causing 401 errors and requires ongoing maintenance. Rate limiting
is not an issue in practice for release checks.
Other