Merge 'release/6.8' back into 'develop'#999
Closed
FantasyTeddy wants to merge 63 commits intodevelopfrom
Closed
Conversation
Replaces the "Time for a beer! Goodbye!" message with a more appropriate "See you next time!" translation across multiple languages, providing a better user experience.
New Image for Nerd Icon
Append version information to AgOpenGPS.zip (#905)
Addresses a potential issue where short curves, whose length is less than the target spacing, could end up with only one point after resampling.
Ensures correct display and input range for the auto-switch dual fix speed setting based on the selected unit system (metric or imperial). The speed is always stored internally as km/h, and the UI is updated to display the corresponding value and range in either km/h or mph. Clamps the value to the correct range to prevent errors.
The loop iterated through all boundaries but always used bndSelect instead of the loop variable q, causing all curves to be generated from the selected boundary instead of each boundary. Changed bndList[bndSelect] to bndList[q] to correctly iterate through each boundary. Fixes #925
Fixed two critical bugs that caused crashes when generating U-turns near inner boundaries: 1. Infinite loop bug: Four instances of incorrect loop iteration where 'cnt2--' was used instead of 'a++', causing infinite loops and array index out of bounds exceptions when the counter went negative. 2. Missing bounds validation: Added checks to ensure ytList and ytList2 are not empty before accessing array elements, preventing crashes when turn generation fails to produce valid paths. These fixes prevent the application from freezing or crashing when U-turns are generated near small inner boundaries. Addresses #926
The Extra Guidelines toggle was duplicated in two locations: 1. Main menu (hamburger menu) - removed 2. Settings -> Configuration Display tab - kept Both controlled the same setting (isSideGuideLines). Removed the main menu item as per issue #914 recommendation to keep it only in the Settings -> Configuration location. Fixes #914
Remove duplicate Extra Guidelines control from main menu
Fix critical U-turn crashes near inner boundaries
Fix boundary curve generation for inner boundaries
Bugfix/imperial tramwidth Fix imperial TramWidth display in ConfigSummaryControl Fix imperial Tool width display in bottom row of Config window
When tool offset is set to exactly half the implement width, the U-turn start and end positions become identical (turnOffset = 0). This caused two issues: 1. Path disappearing: The path would disappear immediately when the tractor reached the start position because the code couldn't distinguish between being at the start versus completing the turn. 2. Wrong direction after turn: When the straight approach and straight exit overlap at the same position, the closest point search would find the approach points instead of the exit points, causing the tractor to turn the wrong direction after completing the turn. Fixes: - Track progress through the U-turn path using maxProgressIndexReached and only allow completion when the vehicle has progressed through at least 50% of the path points - Start closest point search from maxProgressIndexReached - 5 instead of from index 0, preventing the search from jumping back to overlapping start points when the vehicle should be following exit points Addresses #935
The yellow lookahead point was incorrectly shown when using Stanley guidance. Stanley uses a different steering algorithm and doesn't use lookahead points. Possibly introduced in #699 when refactoring to use GLW.DrawPointLayered() - the Stanley mode check from the original code was not carried over. Changes: - Add Stanley mode check to goal point rendering in OpenGL.Designer.cs - Remove duplicate drawing code from CABCurve.cs
Fix goal point displaying in Stanley mode
Put Boundary downloaded from AgShare into BoundaryList to make point spacing heading and winding correct
Fix U-turn failing when offset equals half implement width
Fix naming of chart windows and menu entries
Adds translations for the AgShare Downloader feature into multiple languages, and also fixes some inconsistencies and adds missing translations across all language files.
The "off below" speed setting in Configuration->Sections had two issues: 1. Label hardcoded to "Km/H" regardless of imperial/metric setting 2. Value not converted between km/h and mph Fixed: - Display "MPH" label when imperial units selected - Convert displayed value from km/h to mph (× 0.62137) for imperial - Convert back from mph to km/h (÷ 0.62137) when saving to settings The setting is always stored internally as km/h but displayed/edited in the user's selected units. Fixes #918
When the section 'off below' speed is displayed in imperial units, the code now converts both the Value AND the Minimum/Maximum range of nudCutoffSpeed control. Previously only the Value was converted, which caused ArgumentOutOfRangeException when a saved km/h value was below the minimum after conversion to mph (e.g., saved value of 1 km/h becomes 0.62 mph, which is below the control's minimum of 1). Changes: - Set nudCutoffSpeed.Minimum and Maximum based on unit system - Metric: 0-30 km/h (unchanged) - Imperial: 0-18.6 mph (30 km/h converted) Fixes feedback from PR #955
Replace hardcoded speed conversion factors (0.621371, 0.62137) with centralized Speed.KmhToMph() method across: - FormSteer.cs: 3 conversions for min/max steer speed, guidance limit - Controls.Designer.cs: 1 conversion for max steer speed error message - Position.designer.cs: 1 conversion for min steer speed error message - GUI.Designer.cs: 3 conversions for function speed limit, SpeedMPH property - OpenGL.Designer.cs: 1 conversion for speedometer display
…ty methods - ConfigData.Designer.cs: Replace hardcoded 1.60934 and 1.60 factors with Speed.MphToKmh() and Speed.KmhToMph() - FormSteer.cs: Replace hardcoded 1.609344 factor with Speed.MphToKmh() This completes the consolidation of all speed unit conversions to use the centralized Speed utility class for better maintainability and consistency.
Refines the headland distance display for better readability. Adjusts spacing and formatting for clarity, and switches to feet for imperial units.
Improves distance display consistency by introducing a dedicated formatting function. This function simplifies the formatting of distance values, allowing for easy customization of decimal precision based on the unit of measurement (feet or meters). It ensures consistent display of distance in the user interface.
Fix AgShare Boundary
Fix headland distance display
Fix unit label and conversion for section off below speed
…hare fixed the upload and download fields without a boundary AgShare
Bugfix/932 workedareapreview
* Scale articulated hitch heading adjustment * remove unused stuff
This solves created spikes in boundary line when driving a new boundary and jumps in GNSS occurs during driving under a tree or something. This method is also called when a existing field is loaded. Maybe it needs regeneration of Curves/BoundaryCurves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.