Skip to content

fix(persona-nango-integrations): align test expectation with gpt-5.4 model - #225

Merged
khaliqgant merged 1 commit into
mainfrom
fix/nango-integrations-model-test
Jun 11, 2026
Merged

fix(persona-nango-integrations): align test expectation with gpt-5.4 model#225
khaliqgant merged 1 commit into
mainfrom
fix/nango-integrations-model-test

Conversation

@khaliqgant

Copy link
Copy Markdown
Member

Summary

  • Test expected openai-codex/gpt-5.4-codex but persona JSON uses openai-codex/gpt-5.4 — update the assertion to match the intended model ID

Test plan

  • node --test packages/persona-nango-integrations/test/persona.test.mjs passes (8/8)

🤖 Generated with Claude Code

…model

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@khaliqgant, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 22 minutes and 10 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b3d51741-ffe1-4c99-ac27-1f604bad2c16

📥 Commits

Reviewing files that changed from the base of the PR and between 01488e5 and 94f1cfd.

📒 Files selected for processing (1)
  • packages/persona-nango-integrations/test/persona.test.mjs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/nango-integrations-model-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the expected model name in the persona test suite from 'openai-codex/gpt-5.4-codex' to 'openai-codex/gpt-5.4'. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@khaliqgant
khaliqgant merged commit 3984956 into main Jun 11, 2026
3 checks passed
@khaliqgant
khaliqgant deleted the fix/nango-integrations-model-test branch June 11, 2026 08:14
@agent-relay-code

Copy link
Copy Markdown
Contributor

Reviewed PR #225 against .workforce/pr.diff, changed files, context, package exports, persona JSON, and bot comments. I found no current breakage to fix: the updated test expectation matches packages/persona-nango-integrations/personas/nango-integrations.json and the package’s index.js export.

Addressed comments

  • coderabbitai[bot]: raised no code finding; review was rate-limited and did not start. No code change needed.
  • gemini-code-assist[bot]: reported no review comments and no feedback. No code change needed.

Validation

  • pnpm install --frozen-lockfile: passed after installing pinned pnpm@10.17.1 into the local Node prefix because pnpm was initially missing.
  • pnpm -r run build: passed.
  • pnpm run lint: passed.
  • pnpm run typecheck: passed, including examples.
  • pnpm run test: passed. The changed packages/persona-nango-integrations test suite passed with 8/8 tests.

No repository files were intentionally edited. I’m not printing READY because I cannot verify GitHub-side required check completion or mergeability from this checkout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant