Skip to content

Fix broker precedence for relay MCP injection #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 3 commits into from
Jul 14, 2026
Merged

Fix broker precedence for relay MCP injection #260

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5fc4d8
fix(runtime): prefer broker path for relay MCP
Jul 14, 2026
7be44c7
test(runtime): make relay MCP fallback assertion portable
Jul 14, 2026
5903a15
test(runtime): assert relay MCP fallback is non-empty
Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions packages/runtime/src/relay-mcp.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import test from 'node:test';
import assert from 'node:assert/strict';

import { resolveAgentRelayBrokerBinary } from './relay-mcp.js';

test('broker-only relay MCP prefers BROKER_BINARY_PATH over the Agent Relay CLI', () => {
assert.equal(
resolveAgentRelayBrokerBinary({
AGENT_RELAY_BIN: '/opt/agent-relay',
BROKER_BINARY_PATH: '/opt/agent-relay-broker'
}),
'/opt/agent-relay-broker'
);
});

test('broker-only relay MCP treats an empty Agent Relay CLI override as unset', () => {
assert.equal(
resolveAgentRelayBrokerBinary({ AGENT_RELAY_BIN: ' ' }),
resolveAgentRelayBrokerBinary({})
Comment thread
khaliqgant marked this conversation as resolved.
Outdated
);
Comment thread
khaliqgant marked this conversation as resolved.
});

test('broker-only relay MCP preserves the legacy AGENT_RELAY_BIN broker override', () => {
assert.equal(
resolveAgentRelayBrokerBinary({ AGENT_RELAY_BIN: ' /opt/legacy-agent-relay-broker ' }),
'/opt/legacy-agent-relay-broker'
);
});
2 changes: 1 addition & 1 deletion packages/runtime/src/relay-mcp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export async function resolveAgentRelayBrokerMcpArgs(args: {
}

export function resolveAgentRelayBrokerBinary(env: NodeJS.ProcessEnv): string {
const configured = env.AGENT_RELAY_BIN?.trim() || env.BROKER_BINARY_PATH?.trim();
const configured = env.BROKER_BINARY_PATH?.trim() || env.AGENT_RELAY_BIN?.trim();
if (configured) return configured;
const sandboxBroker = resolveSandboxAgentRelayBrokerBinary();
return sandboxBroker ?? 'agent-relay-broker';
Expand Down
Loading