creating-contract-agnostic-docker --WIP--#58
Open
amessbee wants to merge 15 commits into
Open
Conversation
10 tasks
Contributor
Author
|
@mujahidkay @rabi-siddique @frazarshad @usmanmani1122 @Muneeb147 Need your help to review and test the following on your machines and get feedback. Testing two dapps in tandem can be done as below:
|
dckc
reviewed
Sep 5, 2024
Comment on lines
+10
to
+11
| "docker:bash": "docker compose exec agd bash", | ||
| "docker:make": "docker compose exec agd make -C /workspace/contract", | ||
| "docker:bash": "docker exec agd bash", | ||
| "docker:make": "docker exec agd make -C /ws-agoric-basics/contract", |
Member
There was a problem hiding this comment.
idea: to manage namespace collisions, use an env variable with a default ${AG_CONTAINER:-agd}
and maybe for ws-agoric-basics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a twin of a PR in dapp-offer-up repo.
Goal of this PR is to (maybe partially) close #92. Currently running of
agoriclocalchain and deploying and starting contract are intertwined in this dapp. This is somewhat unnatural as chain should not depend on the files of any specific contract - apart from the ones that designated essential for its running.Further, running a chain independent of a specific contract will allow testing of multiple dapp simultaneously running and interacting with each other which may unlock several scenarios that a developer may want to test for.
As per discussion with @toliaqat, here is a plan:
run-chain.sh) that necessary tasks for running of chain independently.yarn start:contractshould handle most of the heavy work including:dapp-offer-uphere)Makefileinstall-bundle,submit-proposal,voteetc. calls.install-bundle,submit-proposal,voteetc. calls needed to deploy and run the contract using scripts as before.agoricandagdCLI.Link to IBIS document.