fix(cmake): handle no backend audio for cmake and add system libs - #37
Merged
Conversation
AhmedAmrNabil
changed the title
LoayAhmed304
changed the title
LoayAhmed304
approved these changes
Apr 18, 2026
AhmedSobhy01
approved these changes
Apr 18, 2026
…ndor compiled ones
AhmedSobhy01
force-pushed
the
fix/cmake-audio-and-system-lib
branch
from
April 18, 2026 18:14
ae4099e to
916ed2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr introduces two things:
just runalways remakes build config for cmakeUSE_SYSTEM_OPENAL: use system package for OpenalUSE_SYSTEM_ASSIMP: use system package for assimp // will be added after the model loader prUSE_SYSTEM_BULLET: use system package for bullet3 physicsUSE_SYSTEM_GLFW: use system package for glfwUSE_SYSTEM_LIBS: master swtich to enable all 4 optionsif those options are specified and packages are not found, then it auto fallbacks to vendor libs
from your side there will be zero changes and build will go normally
but you can download the library package on linux and enable any of the options for much faster compilation speed
I want @AhmedSobhy01 or @LoayAhmed304 to test on windows just checkout the branch and
just clean && just runon windows, I already tested all options on linux