Skip to content

fix: add alpha mode check for material loading in GLTF #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AhmedAmrNabil merged 2 commits into from
May 2, 2026
Merged

fix: add alpha mode check for material loading in GLTF #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9cddc8
fix: add alpha mode check for material loading in GLTF
AhmedAmrNabil May 2, 2026
ecff08d
chore: rename game window to ArenaRush
AhmedAmrNabil May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified assets/gltf/enemies/corki.glb
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion config/app.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"start-scene": "menu",
"window": {
"title": "Default Game Window",
"title": "Arena Rush",
"size": {
"width": 1280,
"height": 720
Expand Down
3 changes: 2 additions & 1 deletion src/common/model/model.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,8 @@ namespace our {
// albedo texture as it's the only case where it matters
if (material->textureAlbedo) {
aiString alphaMode;
if (mat->Get(AI_MATKEY_GLTF_ALPHAMODE, alphaMode) == AI_SUCCESS) {
if (mat->Get(AI_MATKEY_GLTF_ALPHAMODE, alphaMode) == AI_SUCCESS &&
alphaMode.C_Str() == std::string("MASK")) {
float alphaCutoff = 0.0f;
if (AI_SUCCESS == mat->Get(AI_MATKEY_GLTF_ALPHACUTOFF, alphaCutoff)) {
material->alphaThreshold = alphaCutoff;
Expand Down
Loading