Skip to content

fix: retry commit messages after blank responses - #5606

Open
primorLee wants to merge 1 commit into
Aider-AI:mainfrom
primorLee:fix/commit-message-whitespace
Open

fix: retry commit messages after blank responses#5606
primorLee wants to merge 1 commit into
Aider-AI:mainfrom
primorLee:fix/commit-message-whitespace

Conversation

@primorLee

Copy link
Copy Markdown

Summary

  • normalize each generated commit message before deciding whether fallback is needed
  • continue to the next configured model when a response contains only whitespace
  • add regression coverage for spaces, tabs, and newlines

Fixes #5581

Validation

  • python -m pytest tests/basic/test_repo.py::TestRepo::test_get_commit_message_skips_whitespace_only_response -q — 1 passed
  • python -m pytest tests/basic/test_repo.py -q — 17 passed, 5 skipped on Windows
  • python -m flake8 aider/repo.py tests/basic/test_repo.py --show-source
  • python -m black --check --line-length 100 --preview aider/repo.py tests/basic/test_repo.py
  • python -m isort --check-only --profile black aider/repo.py tests/basic/test_repo.py

Implementation and regression tests were prepared with AI assistance and manually validated against the reported fallback behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: GitRepo.get_commit_message stops fallback on a whitespace-only response

1 participant