fix(run_cmd): read subprocess stdout in chunks instead of single characters - #5625
Open
lx3133584 wants to merge 1 commit into
Open
fix(run_cmd): read subprocess stdout in chunks instead of single characters#5625lx3133584 wants to merge 1 commit into
lx3133584 wants to merge 1 commit into
Conversation
…acters Fixes Aider-AI#5624 Signed-off-by: Liang Xu <lx3133584@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5624.
In
run_cmd_subprocess(), stdout was previously read one character at a time (process.stdout.read(1)) withprint(chunk, end="", flush=True)in each iteration. For commands producing large output (such as verbose test suites or builds during/run,/test, or--auto-test), this introduced significant Python interpreter and text-decoding overhead.Changes
run_cmd_subprocess()to read stdout in 4KB chunks (process.stdout.read(4096)) while preserving real-time output printing and overall stdout capture.run_cmd_subprocessreads stdout in chunks.Verification
pytest tests/basic/test_run_cmd.pyto verify RED (failed on single-char read) and GREEN (passed on chunk read) states.