Skip to content

fix: add Quickplay queue ID 490 and support lobby injection - #244

Open
minzinccs wants to merge 7 commits into
Alban1911:mainfrom
minzinccs:fix/quickplay-queue-490
Open

fix: add Quickplay queue ID 490 and support lobby injection#244
minzinccs wants to merge 7 commits into
Alban1911:mainfrom
minzinccs:fix/quickplay-queue-490

Conversation

@minzinccs

Copy link
Copy Markdown

Thanks a lot for building and maintaining Rose, it's an awesome project!

Context & Issue

In current League of Legends builds, Quickplay uses queue ID 490 (Summoner's Rift with gameMode: "CLASSIC").
Because Rose previously only checked for queue 480 and gameMode in {"SWIFTPLAY", "BRAWL"}, is_swiftplay_mode was never triggered in standard Quickplay lobbies, leaving skins un-injected when entering the game.

Changes

  • Added SWIFTPLAY_QUEUE_IDS = {480, 490} and "QUICKPLAY" mode in lcu/core/lockfile.py.
  • Updated lobby and phase detectors (game_mode_detector.py, lobby_processor.py, phase_handler.py, lcu_swiftplay.py, swiftplay_handler.py) to recognize queue 490 alongside 480.
  • Kept backward compatibility with queue 480.

Syntax verified and logic aligned with LCU queue 490 data.

@minzinccs

Copy link
Copy Markdown
Author

;+: | Feel free to ping me if anything needs tweaking or if any edge cases come up with Quickplay, happy to look into it!
;3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant