fix: add Quickplay queue ID 490 and support lobby injection - #244
Open
minzinccs wants to merge 7 commits into
Open
fix: add Quickplay queue ID 490 and support lobby injection#244minzinccs wants to merge 7 commits into
minzinccs wants to merge 7 commits into
Conversation
Author
|
;+: | Feel free to ping me if anything needs tweaking or if any edge cases come up with Quickplay, happy to look into it! |
…selected classes, please merge THIS
… slots are unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks a lot for building and maintaining Rose, it's an awesome project!
Context & Issue
In current League of Legends builds, Quickplay uses queue ID
490(Summoner's Rift withgameMode: "CLASSIC").Because Rose previously only checked for queue
480andgameMode in {"SWIFTPLAY", "BRAWL"},is_swiftplay_modewas never triggered in standard Quickplay lobbies, leaving skins un-injected when entering the game.Changes
SWIFTPLAY_QUEUE_IDS = {480, 490}and"QUICKPLAY"mode inlcu/core/lockfile.py.game_mode_detector.py,lobby_processor.py,phase_handler.py,lcu_swiftplay.py,swiftplay_handler.py) to recognize queue490alongside480.480.Syntax verified and logic aligned with LCU queue 490 data.