Skip to content

Load Base Controller Extension when autoloading - #216

Merged
tvdeyen merged 2 commits into
AlchemyCMS:mainfrom
mamhoff:autoloadable-extension
Oct 2, 2025
Merged

Load Base Controller Extension when autoloading#216
tvdeyen merged 2 commits into
AlchemyCMS:mainfrom
mamhoff:autoloadable-extension

Conversation

@mamhoff

@mamhoff mamhoff commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

Let's use Zeitwerk to lazy load our extension.

@tvdeyen tvdeyen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A rebase with main should fix specs

@mamhoff
mamhoff force-pushed the autoloadable-extension branch from 30e8f2e to 4bafa9b Compare January 14, 2025 18:13
@tvdeyen
tvdeyen force-pushed the autoloadable-extension branch from 4bafa9b to 844102b Compare January 15, 2025 11:14
@tvdeyen
tvdeyen force-pushed the autoloadable-extension branch from 844102b to 9f3cf62 Compare January 24, 2025 18:08
Comment thread Gemfile Outdated
@tvdeyen

tvdeyen commented Feb 12, 2025

Copy link
Copy Markdown
Member

@mamhoff can this be rebased now?

@mamhoff
mamhoff force-pushed the autoloadable-extension branch from 9f3cf62 to 8456fd9 Compare February 13, 2025 08:53
@tvdeyen
tvdeyen force-pushed the autoloadable-extension branch from 8456fd9 to 4bb58dd Compare October 2, 2025 11:40
@tvdeyen tvdeyen added this to the 8.0 milestone Oct 2, 2025
@codecov

codecov Bot commented Oct 2, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.52%. Comparing base (9c6b463) to head (795c9bd).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          10       10           
  Lines         271      272    +1     
=======================================
+ Hits          267      268    +1     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen
tvdeyen force-pushed the autoloadable-extension branch from 4bb58dd to 1ae660b Compare October 2, 2025 11:55
mamhoff and others added 2 commits October 2, 2025 13:57
This adds the `flickwerk` dependency and changes the base controller
extension to be a patch as in the Flickwerk Readme.
`Devise::Test::Helpers` is deprecated
@tvdeyen
tvdeyen force-pushed the autoloadable-extension branch from 1ae660b to 795c9bd Compare October 2, 2025 11:59
@tvdeyen
tvdeyen enabled auto-merge October 2, 2025 12:00
@tvdeyen
tvdeyen merged commit 92ef705 into AlchemyCMS:main Oct 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants