Load Base Controller Extension when autoloading - #216
Merged
Conversation
tvdeyen
reviewed
Nov 22, 2024
tvdeyen
left a comment
Member
There was a problem hiding this comment.
Thanks. A rebase with main should fix specs
mamhoff
force-pushed
the
autoloadable-extension
branch
from
January 14, 2025 18:13
30e8f2e to
4bafa9b
Compare
tvdeyen
force-pushed
the
autoloadable-extension
branch
from
January 15, 2025 11:14
4bafa9b to
844102b
Compare
tvdeyen
force-pushed
the
autoloadable-extension
branch
from
January 24, 2025 18:08
844102b to
9f3cf62
Compare
tvdeyen
requested changes
Jan 24, 2025
Member
|
@mamhoff can this be rebased now? |
mamhoff
force-pushed
the
autoloadable-extension
branch
from
February 13, 2025 08:53
9f3cf62 to
8456fd9
Compare
tvdeyen
force-pushed
the
autoloadable-extension
branch
from
October 2, 2025 11:40
8456fd9 to
4bb58dd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 10 10
Lines 271 272 +1
=======================================
+ Hits 267 268 +1
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
force-pushed
the
autoloadable-extension
branch
from
October 2, 2025 11:55
4bb58dd to
1ae660b
Compare
This adds the `flickwerk` dependency and changes the base controller extension to be a patch as in the Flickwerk Readme.
`Devise::Test::Helpers` is deprecated
tvdeyen
force-pushed
the
autoloadable-extension
branch
from
October 2, 2025 11:59
1ae660b to
795c9bd
Compare
tvdeyen
approved these changes
Oct 2, 2025
tvdeyen
enabled auto-merge
October 2, 2025 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's use Zeitwerk to lazy load our extension.