fix(User Form): Disable auto_submit on LocaleSelect - #276
Merged
Conversation
tvdeyen
added
backport-to-8.0-stable
tvdeyen
force-pushed
the
locale-select-disable-auto-submit
branch
from
April 14, 2026 09:58
c9ada39 to
b5314ae
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 11 11
Lines 291 291
=======================================
Hits 287 287
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The default behavior of LocaleSelect is to auto submit the form. We do not want this for the user edit form.
tvdeyen
force-pushed
the
locale-select-disable-auto-submit
branch
from
April 14, 2026 17:01
b5314ae to
82a2064
Compare
sascha-karnatz
approved these changes
Apr 15, 2026
sascha-karnatz
left a comment
sascha-karnatz
left a comment
Contributor
There was a problem hiding this comment.
LGTM. We have to update the alchemy branch later.
Member
Author
Thats why we need that approved first ;) |
tvdeyen
removed
backport-to-8.0-stable
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tvdeyen
added a commit
that referenced
this pull request
Apr 16, 2026
[8.2-stable] Merge pull request #276 from AlchemyCMS/locale-select-disable-auto-submit
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default behavior of LocaleSelect is to auto submit the form. We do not want this for the user edit form.
Needs AlchemyCMS/alchemy_cms#3835