Fix: open on linux / xdg-open output's parent dir#19
Merged
AlejandroSuero merged 1 commit intoAlejandroSuero:mainfrom Mar 15, 2025
Merged
Fix: open on linux / xdg-open output's parent dir#19AlejandroSuero merged 1 commit intoAlejandroSuero:mainfrom
AlejandroSuero merged 1 commit intoAlejandroSuero:mainfrom
Conversation
Contributor
Author
|
BTW. Sorry if I did something wrong. My first PR ;) |
AlejandroSuero
approved these changes
Mar 15, 2025
Owner
AlejandroSuero
left a comment
There was a problem hiding this comment.
@tom-gora Thank you for noticing, I overlooked it.
Owner
The only thing that was "wrong" was not using the conventional-commits style of commit message, but it's fine. |
Contributor
Author
Thanks for the feedback :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just a simple condition branch added to commands/open because this was erroring out on linux.
No way was set for automatic open if
is_unixwas true. PResumably b/c it is tricky to determine what is the default file manager in variety of linux environments. The best approximation I came up is directingxdg-opento parent dir of the output file. It should open the location in preferred file manager without focusing on the file, but it should beenough to improve the flow, rather than simply erroring out.
Type of change
How Has This Been Tested?
none
Configuration:
Neovim version (
nvim --version):NVIM v0.10.4
Build type: RelWithDebInfo
LuaJIT 2.1.1720049189
Run "nvim -V1 -v" for more info
Operating system and version:
Fedora Linux 40 Wayland Environment
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areasNOT APPLICABLE/TOO SIMPLISTIC- [ ] I have made corresponding changes to the documentationNOT APPLICABLEand I agree to follow it.