Fix repo smells: stale docs, dead deps, template cruft, CI gaps#30
Merged
Conversation
- README: rewrite Structure/CI sections to match the actual tree and workflow (removed references to nonexistent head/header/footer.html, about.md, blog.md; correct the CI trigger description). - Gemfile: drop unused jekyll-seo-tag (meta is hand-rolled in _includes/meta.html); add html-proofer in a :test group for CI. - Remove dead Disqus code (site.disqus was never configured, so it never rendered): delete _includes/disqus.html and its include in post.html. - default.html: remove the IE<9 html5shiv block (dead http:// googlecode URL) and the leftover "Created with Jekyll Now" comment. - Harden insecure/protocol-relative URLs to https:// (svg-icons StackOverflow link, GoatCounter analytics script). - _config.yml: trim empty footer-links template fields; drop CNAME from exclude (the file no longer exists). - Commit Gemfile.lock for reproducible builds (un-ignore it). - CI: add a pull_request job that runs jekyll build + html-proofer (internal links/images, UTF-8 locale) so branches are verified before merge; gate the CV-build/deploy job to non-PR events. - CLAUDE.md: generalize the stale hard-coded development-branch reference. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019R3LLsWZr5fdbLwuumEov3
html-proofer 5.2.1 pulls in async → console 1.36, which requires Ruby >= 3.3. The workflow pinned Ruby 3.2, so `bundle install` failed to resolve the locked gems. Bump both jobs to Ruby 3.3 to match the committed Gemfile.lock, and update the matching note in CLAUDE.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019R3LLsWZr5fdbLwuumEov3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workflow (removed references to nonexistent head/header/footer.html,
about.md, blog.md; correct the CI trigger description).
_includes/meta.html); add html-proofer in a :test group for CI.
rendered): delete _includes/disqus.html and its include in post.html.
URL) and the leftover "Created with Jekyll Now" comment.
StackOverflow link, GoatCounter analytics script).
exclude (the file no longer exists).
(internal links/images, UTF-8 locale) so branches are verified before
merge; gate the CV-build/deploy job to non-PR events.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_019R3LLsWZr5fdbLwuumEov3