feat: removes getCurrentVersion function and hardcodes modal version to v2#309
Merged
Conversation
…to v2 - Replaced calls to getCurrentVersion() with a fixed 'v2' value. - Simplifies modal logic for adding new parameters. - Ensures new parameters are consistently marked as v2.
helen-m-lin
reviewed
Sep 22, 2025
helen-m-lin
reviewed
Sep 23, 2025
…coding v2 - Added DEFAULT_VERSION at top of job_params.html script. - Replaced all hardcoded 'v2' references with DEFAULT_VERSION. - Keeps modal version logic flexible for future version bumps (e.g., v3).
helen-m-lin
approved these changes
Sep 23, 2025
helen-m-lin
left a comment
helen-m-lin
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Great job decoupling and simplifying the front-end logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #302.