feat: view full job JSON of uploads in UI before submission#314
Conversation
In an unfinished state. Currently has two test columns for development purposes.
- Introduce dedicated `#json-modal` for viewing full job JSON - Update `addTableRow` to include JSON column/button - Adjust table headers to replace "modal" column with "json" - Move logic from settings iframe to JSON `<pre>` display - Simplify function signature (`modalitiesLength` instead of full array)
- Create dedicated Bootstrap modal for job JSON - Wire button click to open modal and display validated job JSON - Print job JSON to console for debugging
|
@helen-m-lin my latest commit tries to tackle this goal:
|
- Removed unused/commented code - Simplified addTableRow logic and corrected modality JSON rowspan
…a-transfer-service into feat-280-view-modality-json
helen-m-lin
left a comment
helen-m-lin
left a comment
There was a problem hiding this comment.
Looks great! I tested this with a few different upload files, including https://github.com/AllenNeuralDynamics/aind-data-transfer-service/blob/dev/docs/examples/behavior_videos_compression.csv which I think is a good example for showing nested modality transformation settings that don't get displayed in the main table.
Great job learning and implementing the modal, event listeners, bootstrap components and styling.
I left 2 minor/nit comments to simplify the code. @mekhlakapoor would you mind also giving this a review in case you have feedback for the UI?
Removes unneeded nesting and redundancy
Updates returned json indentation from 2 to 3 spaces
2 participants
Closes #280
