Release v1.19.0#316
Merged
Merged
Conversation
…to v2 (#309) * feat: removes getCurrentVersion function and hardcodes modal version to v2 - Replaced calls to getCurrentVersion() with a fixed 'v2' value. - Simplifies modal logic for adding new parameters. - Ensures new parameters are consistently marked as v2. * feat: Use DEFAULT_VERSION constant from Jinja context instead of hardcoding v2 - Added DEFAULT_VERSION at top of job_params.html script. - Replaced all hardcoded 'v2' references with DEFAULT_VERSION. - Keeps modal version logic flexible for future version bumps (e.g., v3).
* fix: makes job platform optional * docs: move platform info to Optional Fields * feat: initial commit In an unfinished state. Currently has two test columns for development purposes. * feat: add JSON modal and update table structure - Introduce dedicated `#json-modal` for viewing full job JSON - Update `addTableRow` to include JSON column/button - Adjust table headers to replace "modal" column with "json" - Move logic from settings iframe to JSON `<pre>` display - Simplify function signature (`modalitiesLength` instead of full array) * feat: add JSON modal for viewing full job data - Create dedicated Bootstrap modal for job JSON - Wire button click to open modal and display validated job JSON - Print job JSON to console for debugging * refactor: clean up job table rendering and JSON modal - Removed unused/commented code - Simplified addTableRow logic and corrected modality JSON rowspan * fix: resolve merge conflicts * fix: code cleanup * fix: code cleanup Removes unneeded nesting and redundancy * fix: changes indentation spaces for returned json Updates returned json indentation from 2 to 3 spaces
johendrickson
requested review from
helen-m-lin,
jtyoung84 and
mekhlakapoor
and removed request for
jtyoung84
helen-m-lin
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.