fix: catch exceptions for get_table#3
Merged
Conversation
helen-m-lin
reviewed
Feb 4, 2026
| api_version=api_version, body=body, _request_timeout=10 | ||
| ) | ||
| except allen_powerplatform_client.exceptions.NotFoundException: | ||
| api_response = [] |
There was a problem hiding this comment.
Returning [] could be ambiguous for cases where table exists but is empty.
Instead of only handling NotFoundException, would it make sense to catch all PowerPlatform exceptions?
except allen_powerplatform_client.exceptions.ApiException as e:
raise HTTPException(
status_code=e.status,
detail=e.reason,
)
Collaborator
Author
There was a problem hiding this comment.
I agree that it could be ambiguous. However none of our other services have explicit error handling / raise HTTPExceptions in the server routes. I believe we did this on purpose to keep things simple but I may be misremembering.
I've updated the branch to propagate PowerPlatform exceptions because I do agree that having the actual exceptions could be useful but would be open to your thoughts @jtyoung84
helen-m-lin
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flow was updated to properly propagate an error. This PR updates the get_table route toraise when an exception is caught NotFoundException is caught.
Question: