Cleanup for OpenAPI Generation#14
Merged
Merged
Conversation
Collaborator
Author
|
Merging for now. @jtyoung84 might look into a cleaner solution in the future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into multiple errors when importing
aind-sharepoint-service-async-clientdue to issues with auto-generated enums.Errors include:
(1)
_sharepoint_service_async_client\models\las_projectid.py", line 44 ENUM_102_MINUS_01_MINUS_044_MINUS_10_–_CTY_GENOMICS = '102-01-044-10 – CTY Genomics' ^ SyntaxError: invalid character '–' (U+2013)cause: character '–' in enum value was being used to generate the enum key name in the async client model.
frequency: 5
(2)
raise TypeError('Attempted to reuse key: %r' % key) TypeError: Attempted to reuse key: 'MMPATCHX'cause: the LimsProject model has 2 values: "mMPATCHx" and "mMPatchx". The enum values (default is CAPS) were being used to generate the enum key names. frequency: 2
(3)
ModuleNotFoundError: aind_sharepoint_service_async_client.models.lightcycle import Lightcyclecause: name of module was light_cycle for nsb2019, lightcycle0 for nsb2023. this stems from duplicate naming of enum classes in the 2 nsb lists
frequency: 2
This PR:
Notes:
enumNameMapping, etc)