Skip to content

Fix: HistologyWash mass field expects an int#38

Merged
mekhlakapoor merged 2 commits into
mainfrom
fix-37-histology-wash-mass
May 5, 2026
Merged

Fix: HistologyWash mass field expects an int#38
mekhlakapoor merged 2 commits into
mainfrom
fix-37-histology-wash-mass

Conversation

@mekhlakapoor

@mekhlakapoor mekhlakapoor commented May 5, 2026

Copy link
Copy Markdown
Contributor

closes #37

This PR:

  • updates the definition of HistologyWashData.mass to expect int not Decimal (the openapi generator serializes Decimal as StrictStr so although Decimal works for the server, it fails validation with client)
  • I downloaded all of the histology data from SLIMS to double check the type of the mass field. They were all None or int

@mekhlakapoor mekhlakapoor requested a review from jtyoung84 May 5, 2026 22:31
@mekhlakapoor mekhlakapoor merged commit 60cd836 into main May 5, 2026
3 checks passed
@mekhlakapoor mekhlakapoor deleted the fix-37-histology-wash-mass branch May 5, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ValidationError from HistologyWashData.mass model

2 participants